Skip to content

refactor(fuse/pruning): make pruner hierarchy to chain #9714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jan 25, 2023

Conversation

BohuTANG
Copy link
Member

@BohuTANG BohuTANG commented Jan 24, 2023

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

Note: there is no logic changed, only refactoring, making the code clean.

  • introduce: FusePruner, SegmentPruner, BlockPruner
  • chain the pruner: segment-pruner(RangePruner) -> block-pruner(RangePruner -> BloomPruner -> PagePruner) -> TopNPruner

parts #9702

@vercel
Copy link

vercel bot commented Jan 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated
databend ⬜️ Ignored (Inspect) Jan 25, 2023 at 2:52AM (UTC)

@mergify mergify bot added the pr-refactor this PR changes the code base without new features or bugfix label Jan 24, 2023
@BohuTANG BohuTANG marked this pull request as ready for review January 24, 2023 13:00
@BohuTANG BohuTANG mentioned this pull request Jan 24, 2023
5 tasks
@BohuTANG BohuTANG changed the title refactor(fuse/pruning): make pruner hierarchy refactor(fuse/pruning): make pruner hierarchy to chain Jan 24, 2023
@BohuTANG
Copy link
Member Author

There is an issue with the unit test, check it later.

@BohuTANG BohuTANG marked this pull request as draft January 24, 2023 13:24
@BohuTANG BohuTANG force-pushed the dev-storage-fuse-pruner branch from 29a989d to f043633 Compare January 25, 2023 02:21
@BohuTANG BohuTANG marked this pull request as ready for review January 25, 2023 02:32
@BohuTANG
Copy link
Member Author

Only refactor, let's merged.

@BohuTANG BohuTANG merged commit 1028059 into databendlabs:main Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-refactor this PR changes the code base without new features or bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant