Skip to content
This repository was archived by the owner on Feb 6, 2023. It is now read-only.

Conversation

jjaffeux
Copy link
Contributor

@jjaffeux jjaffeux commented Jun 22, 2022

Info screen is a new screen available when clicking on the channel title while viewing a channel.

This screen contains:

  • about info (unless for direct messages)
  • members list with presence
  • settings form

Note this commit also contains a lot of refactoring to make this possible.

Co-Authored-By: Ella E. [email protected]
Co-Authored-By: Chapoi [email protected]

@jjaffeux jjaffeux force-pushed the members branch 4 times, most recently from d869af5 to 55f7010 Compare June 27, 2022 14:16
Info screen is a new screen available when clicking on the channel title while viewing a channel.

This screen contains:
- about info (unless for direct messages)
- members list with presence
- settings form

Note this commit also contains a lot of refactoring to make this possible.

Co-Authored-By: Ella E. <[email protected]>
Co-Authored-By: Chapoi <[email protected]>
jjaffeux and others added 10 commits June 28, 2022 22:18
Co-Authored-By: Ella E. <[email protected]>
Co-Authored-By: Chapoi <[email protected]>
Co-Authored-By: Ella E. <[email protected]>
Co-Authored-By: Chapoi <[email protected]>
Co-Authored-By: Ella E. <[email protected]>
Co-Authored-By: Chapoi <[email protected]>
Co-Authored-By: Ella E. <[email protected]>
Co-Authored-By: Chapoi <[email protected]>
Co-Authored-By: Ella E. <[email protected]>
Co-Authored-By: Chapoi <[email protected]>
Co-Authored-By: Ella E. <[email protected]>
Co-Authored-By: Chapoi <[email protected]>
Co-Authored-By: Ella E. <[email protected]>
Co-Authored-By: Chapoi <[email protected]>
Co-Authored-By: Ella E. <[email protected]>
Co-Authored-By: Chapoi <[email protected]>
Co-Authored-By: Ella E. <[email protected]>
Co-Authored-By: Chapoi <[email protected]>
Co-Authored-By: Ella E. <[email protected]>
Co-Authored-By: Chapoi <[email protected]>
@jjaffeux jjaffeux changed the title initial commit on draft branch FEATURE: info screen Jun 28, 2022
@jjaffeux jjaffeux marked this pull request as ready for review June 29, 2022 13:36
@jjaffeux jjaffeux merged commit 9c800e0 into main Jun 29, 2022
@jjaffeux jjaffeux deleted the members branch June 29, 2022 13:40
@@ -1012,6 +806,10 @@ body.has-full-page-chat {
}
}

.chat-channel-title {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is affecting chat channel titles in the sidebar. The spacing is now fairly large. We will need to only target the titles for the info screen here.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants