DEV: Update highlight.js to version 11 #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmusaraj
reviewed
Sep 20, 2022
And remove `common.scss` overrides, they aren't needed.
Actually, this isn't needed. For many of the styles, new CSS works fine. (And for the deleted ones... well, it falls back to default from core.) |
pmusaraj
approved these changes
Sep 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the themes with ones compatible with the current version of hljs.
However, the hack we had of unsetting our styles to get the ones from this theme are not working anymore very well, since the styles from the CSS files here are not getting priority.
That said, it appears that this broke independently https://meta.discourse.org/t/codeblock-theme-picker/146396/22?u=falco