Skip to content

Added a ClientInterface #1249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 24, 2022
Merged

Added a ClientInterface #1249

merged 3 commits into from
Aug 24, 2022

Conversation

ezimuel
Copy link
Contributor

@ezimuel ezimuel commented Aug 23, 2022

This PR fixes #1227

This was referenced Aug 23, 2022
Closed
Closed
@ezimuel ezimuel requested a review from picandocodigo August 23, 2022 14:46
@hkulekci
Copy link
Contributor

hkulekci commented Aug 23, 2022 •
edited
Loading

I think we need to change the AbstractEndpoint::__construct method parameter types from Client to ClientInterface.

@ezimuel
Copy link
Contributor Author

ezimuel commented Aug 24, 2022

@hkulekci good catch, thanks! I updated the PR.

@ezimuel ezimuel merged commit eba27a8 into 8.4 Aug 24, 2022
@ezimuel ezimuel deleted the client-interface branch August 24, 2022 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@picandocodigo picandocodigo picandocodigo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ezimuel @hkulekci @picandocodigo