-
Notifications
You must be signed in to change notification settings - Fork 462
[Azure Logs] Handle event.original field from upstream forwarders #3639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Upstream event forwarders like Logstash can add their `event.original` field, depending on the circumstances (specific configurations or tool versions). With the change, the pipeline will honor the event.original field over the message field, when it exists.
Note for reviewers: I'm not a pipeline expert, and I'd love to hear from you if there are better ways to achieve the same goal. |
🌐 Coverage report
|
Another note for the reviewers: I'd also love to add a test for this change, but the test infrastructure focuses on the message, and AFAIK it does not offer options to customize event fields. Any advice about how to archive this? |
This seems like this would be an issue for every integration of logstash adds an |
Agree with @legoguy1000 and I think the fix should be on logstash side. |
@kaiyan-sheng i agree this fix should be made on the logstash side, but I think it's reasonable to add this mitigation here as well. especially since we can release the integration independently and ahead of logstash. the only consideration is if this change has any performance impact on the pipeline (it looks like it would be pretty minimal to me)? the logstash issue to track the fix over there is here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these changes look good to me - thanks @zmoog. just one question regarding performance, any idea if the addition of these conditionals come with any measurable perf hit?
after following up on the perf element, we do not have anything to worry about here. |
This sounds good; I'll compare this change's performance impact with the previous version to ensure it doesn't move the needle in the wrong direction. |
What does this PR do?
With this PR, the Azure Logs pipelines will use the
event.original
field over themessage
field when it exists in the actual event.Upstream event forwarders like Logstash can add their
event.original
field, depending on the circumstances (specificconfigurations or tool versions), causing issues like #3636.
Checklist
changelog.yml
file.Related issues