Skip to content

[Azure Logs] Remove extra overview heading #4382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 5, 2022

Conversation

zmoog
Copy link
Contributor

@zmoog zmoog commented Oct 5, 2022

What does this PR do?

Remove the 'Overview' heading at the doc beginning.

TIL that https://docs.elastic.co/integrations/azure automatically adds one on its own, so we should omit it in the source code to avoid duplicates.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Screenshots

CleanShot 2022-10-05 at 08 50 06@2x

CleanShot 2022-10-05 at 08 50 01@2x

docs.elastic.co automatically adds an 'Overview' heading at the doc beginning, so we should omit it in the source code to avoid duplicates.
@zmoog zmoog added bug Something isn't working, use only for issues docs labels Oct 5, 2022
@zmoog zmoog self-assigned this Oct 5, 2022
@zmoog zmoog marked this pull request as ready for review October 5, 2022 07:05
@zmoog zmoog requested a review from a team as a code owner October 5, 2022 07:05
@zmoog zmoog changed the title Remove overview headings [Azure Logs] Remove extra overview heading Oct 5, 2022
@elasticmachine
Copy link

elasticmachine commented Oct 5, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-10-05T07:03:40.961+0000

  • Duration: 13 min 28 sec

Test stats 🧪

Test Results
Failed 0
Passed 123
Skipped 0
Total 123

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Oct 5, 2022

🚀 Benchmarks report

Package azure 👍(1) 💚(1) 💔(8)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
springcloudlogs 3875.97 1980.2 -1895.77 (-48.91%) 💔
activitylogs 1312.34 622.28 -690.06 (-52.58%) 💔
application_gateway 2288.33 1477.1 -811.23 (-35.45%) 💔
auditlogs 1996.01 1396.65 -599.36 (-30.03%) 💔
firewall_logs 1980.2 1402.52 -577.68 (-29.17%) 💔
identity_protection 4237.29 2053.39 -2183.9 (-51.54%) 💔
platformlogs 3937.01 2386.63 -1550.38 (-39.38%) 💔
signinlogs 1980.2 967.12 -1013.08 (-51.16%) 💔

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (10/10) 💚
Files 86.364% (19/22)
Classes 86.364% (19/22)
Methods 83.422% (156/187)
Lines 85.011% (2779/3269)
Conditionals 100.0% (0/0) 💚

@zmoog zmoog merged commit 3833c3d into main Oct 5, 2022
@zmoog zmoog deleted the azure-logs-remove-overview-heading branch October 5, 2022 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working, use only for issues docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants