Skip to content

[Azure Logs] change default settings #4476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

zmoog
Copy link
Contributor

@zmoog zmoog commented Oct 19, 2022

What does this PR do?

This PR changes two things:

  1. Updates the event hub description in general settings; it recommends using one event hub per integration and adds a link to the relevant section in the documentation.
  2. Enables the generic event hub integration while all the others stay disabled.

The idea is to provide a default configuration for the user where the integration ingests logs OOTB. Users can build their use case from this reasonable default.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

Screenshots

Improve the description of the Event Hub option.

CleanShot 2022-10-19 at 16 04 42@2x

Add a direct recommendation and a link to the relevant section in the
integration documentation.
@zmoog zmoog added the enhancement New feature or request label Oct 19, 2022
@elasticmachine
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

elasticmachine commented Oct 19, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-11-04T14:31:59.754+0000

  • Duration: 15 min 46 sec

Test stats 🧪

Test Results
Failed 0
Passed 123
Skipped 0
Total 123

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Oct 19, 2022

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (10/10) 💚
Files 86.364% (19/22) 👎 -10.924
Classes 86.364% (19/22) 👎 -10.924
Methods 83.422% (156/187) 👎 -7.252
Lines 85.011% (2779/3269) 👎 -6.451
Conditionals 100.0% (0/0) 💚

@ravikesarwani
Copy link

Looks good from my side.

@zmoog zmoog marked this pull request as ready for review October 19, 2022 16:53
@zmoog zmoog requested a review from a team as a code owner October 19, 2022 16:53
@zmoog
Copy link
Contributor Author

zmoog commented Nov 4, 2022

/test

@zmoog zmoog merged commit f754dbe into elastic:main Nov 4, 2022
@zmoog zmoog deleted the zmoog/azure-logs-disable-by-default-part-ii branch November 4, 2022 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants