Skip to content

Add missing event fields #6028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 4, 2023
Merged

Add missing event fields #6028

merged 2 commits into from
May 4, 2023

Conversation

jennypavlova
Copy link
Member

@jennypavlova jennypavlova commented Apr 28, 2023 •
edited
Loading

What does this PR do?

This PR adds the missing event.* field mapping. Some of the mappings are already added ion this PR

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

Build the integrations following the guide and check if the mapping is correct

Related issues

@jennypavlova jennypavlova added bug Something isn't working, use only for issues Integration:elasticsearch Elasticsearch Integration:kibana Kibana Integration:logstash Logstash Team:Infra Monitoring UI - DEPRECATED Label for the Infrastructure Monitoring UI team. - DEPRECATED - Use Team:obs-ux-infra_services labels Apr 28, 2023
@jennypavlova jennypavlova self-assigned this Apr 28, 2023
@jennypavlova jennypavlova force-pushed the 5869-stack-monitoring-missing-mapping-for-eventcreated-missing-in-the-integration-packages branch from aacce13 to 2159af0 Compare April 28, 2023 13:32
@jennypavlova jennypavlova force-pushed the 5869-stack-monitoring-missing-mapping-for-eventcreated-missing-in-the-integration-packages branch from 2159af0 to bcca0ec Compare April 28, 2023 13:33
@elasticmachine
Copy link

elasticmachine commented Apr 28, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-05-02T13:33:40.213+0000

  • Duration: 31 min 9 sec

Test stats 🧪

Test Results
Failed 0
Passed 113
Skipped 0
Total 113

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Apr 28, 2023 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (9/9) 💚
Files 100.0% (19/19) 💚
Classes 100.0% (19/19) 💚
Methods 91.878% (181/197) 👍 66.878
Lines 90.456% (834/922) 👎 -9.544
Conditionals 100.0% (0/0) 💚

@jennypavlova jennypavlova marked this pull request as ready for review May 2, 2023 14:05
@jennypavlova jennypavlova requested a review from a team as a code owner May 2, 2023 14:05
@crespocarlos crespocarlos self-requested a review May 4, 2023 10:47
crespocarlos
crespocarlos approved these changes May 4, 2023
View reviewed changes
Copy link
Contributor

@crespocarlos crespocarlos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👏

@jennypavlova jennypavlova merged commit e59f29f into elastic:main May 4, 2023
@jennypavlova jennypavlova deleted the 5869-stack-monitoring-missing-mapping-for-eventcreated-missing-in-the-integration-packages branch May 4, 2023 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crespocarlos crespocarlos crespocarlos approved these changes

Assignees

@jennypavlova jennypavlova

Labels
bug Something isn't working, use only for issues Integration:elasticsearch Elasticsearch Integration:kibana Kibana Integration:logstash Logstash Team:Infra Monitoring UI - DEPRECATED Label for the Infrastructure Monitoring UI team. - DEPRECATED - Use Team:obs-ux-infra_services
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Stack Monitoring] Missing mapping for "event.created" missing in the integration packages
3 participants
@jennypavlova @elasticmachine @crespocarlos