Skip to content

[O11y][PHP-FPM] Add metric_type for pool and process data streams #7527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 21, 2023
Merged

[O11y][PHP-FPM] Add metric_type for pool and process data streams #7527

merged 6 commits into from
Sep 21, 2023

Conversation

harnish-crest-data
Copy link
Contributor

  • Enhancement

What does this PR do?

  • Add metric_type for pool and process data streams.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

@harnish-crest-data harnish-crest-data added enhancement New feature or request Integration:php_fpm PHP-FPM labels Aug 24, 2023
@harnish-crest-data harnish-crest-data self-assigned this Aug 24, 2023
@harnish-crest-data harnish-crest-data marked this pull request as ready for review August 24, 2023 09:13
@harnish-crest-data harnish-crest-data requested a review from a team as a code owner August 24, 2023 09:13
@elasticmachine
Copy link

elasticmachine commented Aug 24, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-09-20T06:06:24.645+0000

  • Duration: 16 min 10 sec

Test stats 🧪

Test Results
Failed 0
Passed 12
Skipped 0
Total 12

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Aug 24, 2023 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (2/2) 💚
Files 100.0% (2/2) 💚 5.534
Classes 100.0% (2/2) 💚 5.534
Methods 100.0% (16/16) 💚 8.402
Lines 95.763% (226/236) 👍 8.21
Conditionals 100.0% (0/0) 💚

ali786XI
ali786XI approved these changes Aug 29, 2023
View reviewed changes
Copy link
Contributor

@ali786XI ali786XI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ritalwar
ritalwar reviewed Sep 13, 2023
View reviewed changes
@ritalwar
Copy link
Contributor

@muthu-mps As this PR is ready, do you believe it's better to merge this before proceeding with the GA release of this package?

@muthu-mps
Copy link
Contributor

@muthu-mps As this PR is ready, do you believe it's better to merge this before proceeding with the GA release of this package?

Yes, We can merge this PR before making the integration GA.

ritalwar
ritalwar approved these changes Sep 20, 2023
View reviewed changes
Copy link
Contributor

@ritalwar ritalwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@harnish-crest-data harnish-crest-data merged commit 34b790a into elastic:main Sep 21, 2023
@elasticmachine
Copy link

Package php_fpm - 0.6.1 containing this change is available at https://epr.elastic.co/search?package=php_fpm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ritalwar ritalwar ritalwar approved these changes

@ali786XI ali786XI ali786XI approved these changes

Assignees

@harnish-crest-data harnish-crest-data

Labels
enhancement New feature or request Integration:php_fpm PHP-FPM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[O11y][PHP-FPM] Missing metric_type in fields.yml file
5 participants
@harnish-crest-data @elasticmachine @ritalwar @muthu-mps @ali786XI