Skip to content

Conversation

amitkanfer
Copy link
Contributor

What does this PR do?

Fixing couple of charts in the agent integration

Added a new dataset to include both metrics and logs data streams for the relevant charts

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

image
image

@amitkanfer amitkanfer requested a review from a team as a code owner September 6, 2023 10:42
@amitkanfer amitkanfer requested a review from joshdover September 6, 2023 10:43
@joshdover
Copy link
Contributor

We need to make the same fixes to the metric viz's at the top of this dashboard as well as the "Total Ingest rates" at the bottom. I think it makes sense to do all of those in a single PR so the dashboard is coherent and adds up correctly.

@elasticmachine
Copy link

elasticmachine commented Sep 6, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-09-06T11:51:52.540+0000

  • Duration: 13 min 28 sec

Test stats 🧪

Test Results
Failed 0
Passed 37
Skipped 0
Total 37

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Sep 6, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚
Classes 100.0% (0/0) 💚
Methods 33.333% (25/75) 👎 -66.667
Lines 100.0% (0/0) 💚
Conditionals 100.0% (0/0) 💚

Copy link
Contributor

@joshdover joshdover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amitkanfer amitkanfer merged commit 499fe56 into elastic:main Sep 6, 2023
@elasticmachine
Copy link

Package elastic_agent - 1.12.1 containing this change is available at https://epr.elastic.co/search?package=elastic_agent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants