Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: equinor/webviz-subsurface-components
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: well-log-viewer@1.13.0
Choose a base ref
...
head repository: equinor/webviz-subsurface-components
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: well-log-viewer@1.13.1
Choose a head ref
  • 4 commits
  • 8 files changed
  • 4 contributors

Commits on Sep 5, 2024

  1. fix(grid3d): Fixed coloring if no property data proived (#2224)

    1) Fixed case when no property data is given to Grid3DLayer coloring by
    undefined property is performed.
    2) Fixed precision issue with undefined property value in case of
    continuous property.
    
    ---------
    
    Co-authored-by: leonid.polukhin <leonid.polukhin@aspentech.com>
    LeonidPolukhin and leonid.polukhin authored Sep 5, 2024
    Copy the full SHA
    3216861 View commit details
  2. Copy the full SHA
    d9ec035 View commit details

Commits on Sep 6, 2024

  1. fix: div size in the RTC Tab Layout story (#2153)

    Close  #2015
    Vladimir-Kokin authored Sep 6, 2024
    Copy the full SHA
    6b6a3bd View commit details
  2. Copy the full SHA
    94510ee View commit details
7 changes: 7 additions & 0 deletions typescript/packages/subsurface-viewer/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,10 @@
## [0.30.1](https://github.com/equinor/webviz-subsurface-components/compare/subsurface-viewer@0.30.0...subsurface-viewer@0.30.1) (2024-09-05)


### Bug Fixes

* **grid3d:** Fixed coloring if no property data proived ([#2224](https://github.com/equinor/webviz-subsurface-components/issues/2224)) ([3216861](https://github.com/equinor/webviz-subsurface-components/commit/3216861d1e2c24e70bee593836329429aa56ef3c))

# [0.30.0](https://github.com/equinor/webviz-subsurface-components/compare/subsurface-viewer@0.29.1...subsurface-viewer@0.30.0) (2024-09-04)


2 changes: 1 addition & 1 deletion typescript/packages/subsurface-viewer/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@webviz/subsurface-viewer",
"version": "0.30.0",
"version": "0.30.1",
"description": "3D visualization component for subsurface reservoir data",
"keywords": [
"subsurface",
Original file line number Diff line number Diff line change
@@ -412,7 +412,9 @@ export default class Grid3DLayer extends CompositeLayer<Grid3DLayerProps> {

private getUndefinedPropertyValue(): number {
if (typeof this.props.undefinedPropertyValue === "number") {
return this.props.undefinedPropertyValue;
//Precision should be reduced to single for correct comparing property values
// with undefined property value in the webworker.
return new Float32Array([this.props.undefinedPropertyValue])[0];
}
if (this.props.propertiesData instanceof Uint16Array) {
return 0xffff;
@@ -421,8 +423,24 @@ export default class Grid3DLayer extends CompositeLayer<Grid3DLayerProps> {
}

private getUndefinedPropertyColor(): [number, number, number] {
const colorFunc = this.props.colorMapFunction;
if (
this.props.propertiesData.length === 0 &&
this.isColorMapFunctionConstantColor(colorFunc)
) {
return [colorFunc[0] / 255, colorFunc[1] / 255, colorFunc[2] / 255];
}
return this.props.undefinedPropertyColor ?? [0.8, 0.8, 0.8];
}

private isColorMapFunctionConstantColor(
colorFunc: Uint8Array | colorMapFunctionType | undefined
): colorFunc is Uint8Array {
return (
(Array.isArray(colorFunc) || colorFunc instanceof Uint8Array) &&
colorFunc.length >= 3
);
}
}

Grid3DLayer.layerName = "Grid3DLayer";
7 changes: 7 additions & 0 deletions typescript/packages/well-log-viewer/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,10 @@
## [1.13.1](https://github.com/equinor/webviz-subsurface-components/compare/well-log-viewer@1.13.0...well-log-viewer@1.13.1) (2024-09-06)


### Bug Fixes

* div size in the RTC Tab Layout story ([#2153](https://github.com/equinor/webviz-subsurface-components/issues/2153)) ([6b6a3bd](https://github.com/equinor/webviz-subsurface-components/commit/6b6a3bddc9f8fecb6da76d607e30eab722d5bee2)), closes [#2015](https://github.com/equinor/webviz-subsurface-components/issues/2015)

# [1.13.0](https://github.com/equinor/webviz-subsurface-components/compare/well-log-viewer@1.12.7...well-log-viewer@1.13.0) (2024-09-04)


2 changes: 1 addition & 1 deletion typescript/packages/well-log-viewer/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@webviz/well-log-viewer",
"version": "1.13.0",
"version": "1.13.1",
"description": "",
"main": "dist/index.js",
"types": "dist/index.d.ts",
Original file line number Diff line number Diff line change
@@ -28,7 +28,7 @@ const RTCWellLogViewer: React.FunctionComponent = () => {

// storybook page
const meta: Meta<typeof RTCWellLogViewer> = {
title: "WellLogViewer / Examples / classification layout",
title: "WellLogViewer/Demo/ClassificationLayout",
component: RTCWellLogViewer,
};

Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Original file line number Diff line number Diff line change
@@ -9,7 +9,7 @@
}
.interior {
flex: 1;
height: 0%;
height: 0pt;
width: 100%;
display: flex;
flex-direction: row;
@@ -20,7 +20,7 @@
.middle{
flex: 1;
height: 100%;
width: 0%;
width: 0pt;
display: flex;
flex-direction: column;
}