fix(fcm): correct the iidEndpoint endpoints used for topic management#335
Merged
hiranya911 merged 2 commits intofirebase:devfrom Feb 25, 2020
Merged
fix(fcm): correct the iidEndpoint endpoints used for topic management#335hiranya911 merged 2 commits intofirebase:devfrom
hiranya911 merged 2 commits intofirebase:devfrom
Conversation
74bda9f to
63cc148
Compare
hiranya911
suggested changes
Feb 20, 2020
Contributor
There was a problem hiding this comment.
Thanks for the PR. Both these URL patterns (/v1/:suffix and /v1:suffix) resolve to the same endpoint. So there's no actual bug here. Although I do prefer the /v1:suffix format, since that's what's documented.
And please change the base branch of the PR to dev. We don't merge to master directly.
| iidEndpoint = "https://iid.googleapis.com/iid/v1" | ||
| iidSubscribe = ":batchAdd" | ||
| iidUnsubscribe = ":batchRemove" | ||
| iidEndpoint = "https://iid.googleapis.com/iid" |
Contributor
There was a problem hiding this comment.
Instead of this, let's change how the URL is constructed in the makeTopicManagementRequest() function.
iidSubscribe = "batchAdd"
iidUnsubscribe = "batchRemove"
fmt.Sprintf("%s:%s", c.iidEndpoint, req.op)
This will cause a test failure, so we need to update the tests too.
fe513b8 to
a5e5cf5
Compare
According to the document https://developers.google.com/instance-id/reference/server, the endpoints should be: https://iid.googleapis.com/iid/v1:batchAdd https://iid.googleapis.com/iid/v1:batchRemove NOT: https://iid.googleapis.com/iid/v1/:batchAdd https://iid.googleapis.com/iid/v1/:batchRemove
a5e5cf5 to
3303464
Compare
Contributor
Author
|
Thank you for reviewing my PR. I have changed the base branch to dev, and fix the tests and the I am not sure that both However when requesting to Another question, is there any plan to support the |
hiranya911
approved these changes
Feb 25, 2020
Contributor
hiranya911
left a comment
There was a problem hiding this comment.
LGTM. Thanks @rueian for the PR.
hiranya911
added a commit
that referenced
this pull request
Apr 23, 2020
* chore: Removed Travis CI integration (#326) * chore: Added Actions-based release workflow (#331) * chore: Added Actions-based release workflow * Set GOPATH * Fixed working directory for tests * Decrypting credentials into the testdata directory * Added preflight and post check scripts * chore: Running CI workflow on pull_request (#338) * fix(fcm): correct the iidEndpoint endpoints used for topic management (#335) According to the document https://developers.google.com/instance-id/reference/server, the endpoints should be: https://iid.googleapis.com/iid/v1:batchAdd https://iid.googleapis.com/iid/v1:batchRemove NOT: https://iid.googleapis.com/iid/v1/:batchAdd https://iid.googleapis.com/iid/v1/:batchRemove * fix(fcm): Fix documents of FCM batch request limit (#347) Co-authored-by: Hiranya Jayathilaka <hiranya911@gmail.com> * fix: Deferring credential loading until required (#361) * Bumped version to 3.12.1 (#363) * chore: Specifying correct working directory for staging command (#365) Co-authored-by: Rueian <rueiancsie@gmail.com> Co-authored-by: 178inaba <178inaba.git@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to the document https://developers.google.com/instance-id/reference/server,
the endpoints should be:
https://iid.googleapis.com/iid/v1:batchAdd
https://iid.googleapis.com/iid/v1:batchRemove
NOT:
https://iid.googleapis.com/iid/v1/:batchAdd
https://iid.googleapis.com/iid/v1/:batchRemove
RELEASE NOTE: Updated the remote endpoint used by the topic management operations.