Skip to content

firebase-perf is not compliant with market policies #4045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yin-haoran opened this issue Aug 31, 2022 · 6 comments
Closed

firebase-perf is not compliant with market policies #4045

yin-haoran opened this issue Aug 31, 2022 · 6 comments

Comments

@yin-haoran
Copy link

yin-haoran commented Aug 31, 2022

Getting running processes before privacy agreement is not compliant with market policies

com.google.firebase.perf.session.gauges.GaugeMetadataManager.getCurrentProcessName() {
    // activityManager.getRunningAppProcesses()
}
@google-oss-bot
Copy link
Contributor

I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.

@yin-haoran yin-haoran changed the title Getting running processes before privacy agreement is not compliant with market policies firebase-perf is not compliant with market policies Aug 31, 2022
@argzdev
Copy link
Contributor

argzdev commented Sep 1, 2022

Hi @yin-haoran, thanks for reporting. Which market is it non-compliant with? Also can you share a screenshot of the error of the non compliance?

@yin-haoran
Copy link
Author

Tencent Appstore.

stack information of the error of the non compliance as follow

android.app.ActivityManager.getRunningAppProcesses(ActivityManager.java:3564)<[---com.google.firebase.perf.session.gauges.GaugeMetadataManager.getCurrentProcessName(GaugeMetadataManager.java:3)<---com.google.firebase.perf.session.gauges.GaugeMetadataManager.<init](https://github.com/firebase/firebase-android-sdk/issues/---com.google.firebase.perf.session.gauges.GaugeMetadataManager.getCurrentProcessName(GaugeMetadataManager.java:3)%3C---com.google.firebase.perf.session.gauges.GaugeMetadataManager.%3Cinit)>(GaugeMetadataManager.java:8)<---com.google.firebase.perf.session.gauges.GaugeMetadataManager.<init>(GaugeMetadataManager.java:1)<---com.google.firebase.perf.session.gauges.GaugeManager.initializeGaugeMetadataManager(GaugeManager.java:1)<---com.google.firebase.perf.session.SessionManager.lambda$setApplicationContext$0(SessionManager.java:1)<---com.google.firebase.perf.session.SessionManager.a(Unknown Source:0)<---com.google.firebase.perf.session.a.run(Unknown Source:6)<---java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:457)<---java.util.concurrent.FutureTask.run(FutureTask.java:266)<---java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1162)<---java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:636)<---java.lang.Thread.run(Thread.java:764)
<style> </style>

android.app.ActivityManager.getRunningAppProcesses(ActivityManager.java:3564)<---com.google.firebase.perf.session.gauges.GaugeMetadataManager.getCurrentProcessName(GaugeMetadataManager.java:3)<---com.google.firebase.perf.session.gauges.GaugeMetadataManager.(GaugeMetadataManager.java:8)<---com.google.firebase.perf.session.gauges.GaugeMetadataManager.(GaugeMetadataManager.java:1)<---com.google.firebase.perf.session.gauges.GaugeManager.initializeGaugeMetadataManager(GaugeManager.java:1)<---com.google.firebase.perf.session.SessionManager.lambda$setApplicationContext$0(SessionManager.java:1)<---com.google.firebase.perf.session.SessionManager.a(Unknown Source:0)<---com.google.firebase.perf.session.a.run(Unknown Source:6)<---java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:457)<---java.util.concurrent.FutureTask.run(FutureTask.java:266)<---java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1162)<---java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:636)<---java.lang.Thread.run(Thread.java:764)

@argzdev
Copy link
Contributor

argzdev commented Sep 2, 2022

Got it, thanks for the details @yin-haoran. I'll let our engineers know about this.

@raymondlam
Copy link
Member

Thanks @yin-haoran for reporting this. I've discussed with the team and we will remove the call for getRunningAppProcesses to get the process name of the app since we don't use that data.

In the meantime, if you haven't already, you can enable opt-in into performance collection for your users by adding the following <meta-data> element to your app’s AndroidManifest.xml file:

  <application>
    <meta-data
      android:name="firebase_performance_collection_enabled"
      android:value="false" />
  </application>

After your user's have agreed to the privacy agreement, you can enable Firebase Performance collection with

FirebasePerformance.getInstance().setPerformanceCollectionEnabled(true);

@raymondlam
Copy link
Member

Closing as the call to getRunningAppProcesses should be removed in the latest release.

@firebase firebase locked and limited conversation to collaborators Nov 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants