-
Notifications
You must be signed in to change notification settings - Fork 606
Circular dependency between the following tasks: :app:dataBindingGenBaseClassesDebug #5925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
We're experiencing the same issue in our project after upgrading to 3.0.0. |
Totally agree, circular dependency crashes the build starting from 3.0.0 |
Same here. classpath ("com.google.firebase:firebase-crashlytics-gradle:2.9.9") with firebase_bom_version = "33.0.0" is working. I think best is to stay at that version. |
We are experiencing this issue as well, thought it was another AGP update issue. |
Hey everyone! I have informed the Crashlytics engineers and they are working on it. In the meantime, please stick to This issue will be updated once the fix is released. Thank you! |
This is because the The We don't have a good api to query for only the static sources. So instead, I will update the task to decide if it's up to date by the heuristic: Both I will update this issue when the fix is released. |
On my end, it's |
Thanks for the details everybody! I have implemented a fix for this and verified it with viewBinder. I also added new functional tests that validate use cases with code generation. This issue was caused by anything that generates code and depends on Android resources. I am going to update here again when it is released. For now, anybody can try the latest changes from the pre-release build #5733. |
Hey Guys, Thanks for sharing. Also have faced the same issue. this works fine |
I have this too, but the error is a bit longer than the above:
BTW, I use this (as 2.9.9 worked fine with it) :
How do I switch to the "id..." ? Or even to kts format? EDIT: tried to copy from a new project. I think it works fine. |
I'm seeing a slightly different error, but I'm assuming that it is related to this issue:
This error only occurred after updating from 2.9.9 to 3.0.0 |
Crashlytics 3.0 breaks builds - see firebase/firebase-android-sdk#5925.
Crashlytics 3.0 breaks builds - see firebase/firebase-android-sdk#5925. Fixes #2686.
Idem on my side, |
@mrober Some of use uses googleServicesResourceRoot for manual handling but seems it's also removed in 3.0.0, please also document how we are supposed to do it after this please.
|
Keep googleFirebaseCrashlyticsGradle to "2.9.9" due to a bug: firebase/firebase-android-sdk#5925
I just got this too after updating Android Studio etc.; thanks for the workaround and that you're getting it fixed! |
@Tolriq the If you want to have the same app package name in different Firebase projects, you can follow https://developers.google.com/android/guides/google-services-plugin#adding_the_json_file . Basically you can put different If you want different package names for different variants in the same Firebase project, that will work out of the box. Just re-download your |
@mrober I do not use the json and the associated plugin and do not want to, I also disable the mapping upload. That plugin actually brings nothing for my needs, just ton of pains when updating gradle and AGP. I have everything already generated the way I want and needed and just want crashlytics to use that. I already also have tons of wrapping to ensure proper controllable startup via ressourcewrapper. Please leave a way to continue to work like that. |
Am I reading this correctly that it was working in 3.0.0-alpha03 but not when 3.0.0 was released? Is there an estimate when it will be fixed in a non-alpha/beta version? |
I am facing same issue with classpath 'com.google.firebase:firebase-crashlytics-gradle:3.0.0' Circular dependency between the following tasks: |
@Tolriq can you please file a new issue about the no google-services plugin use case you have? We will do something for it. For now, you could set |
Hey everybody, we will release 3.0.1 with this issue fixed in the next couple days. Sorry for the delay, we are pretty stretched right now. Thank you everyone for providing all the details and feedback! |
Are there any new breaking code changes on 3.x versions? |
@mrober Thank you. Seems I don't use any of these and I don't even know what they are. |
facing the same issue any solution FAILURE: Build failed with an exception.
(*) - details omitted (listed previously)
(*) - details omitted (listed previously)
BUILD FAILED in 709ms |
same issue |
same issue |
To everyone experiencing the same problem: could you kindly consider clicking the 👍 reaction on the initial comment instead of posting a new comment simply stating "same issue"? Such comments don't offer any new insights and only clutter the feed for those following this matter. |
Confirmed fixed with 3.0.1 👍🏽 |
Hi everybody, version 3.0.1 has been released which resolves this issue. Thank you everybody for providing all the details! Closing this issue, but if anybody runs into any other problems please open a new issue. |
@mrober For the record it seems with 3.0.1 the plugin no more yell on missing xml generated by the google plugin and so the googleServicesResourceRoot hack is not necessary anymore so I don't need it and won't open an issue as WAI. |
After upgrading to 3.0.1 I get this new error: #5962 |
use this classpath("com.google.firebase:firebase-crashlytics-gradle:3.0.1") |
|
use this classpath("com.google.firebase:firebase-crashlytics-gradle:3.0.1") implementation 'com.google.firebase:firebase-crashlytics:19.0.0' implementation("com.google.firebase:firebase-crashlytics:19.0.0") |
I change crashingly to 2.9.9, and it works. So I guess u either add .jar file directly if using maven debugger or change to 2.9.9 if u use Groovy |
[REQUIRED] Step 2: Describe your environment
[REQUIRED] Step 3: Describe the problem
After upgrading to v3.0.0 of the Crashlytics Gradle plugin I get the following build error:
Steps to reproduce:
A reproducible build can be found in firebase/quickstart-android#1608
Confirmed that the build succeeds with version
2.9.9
: firebase/quickstart-android#1607The text was updated successfully, but these errors were encountered: