-
Notifications
You must be signed in to change notification settings - Fork 606
Use lazy encoding in utf-8 encoded string comparison #6706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Release note changesThe following release notes were modified. Please ensure they look correct. Release Notesfirebase-firestore### {{firestore}} version 25.1.3 {: #firestore_v25-1-3}
* {{fixed}} Use lazy encoding in UTF-8 encoded byte comparison for strings to solve performance issues. GitHub [#6706](//github.com/firebase/firebase-android-sdk/issues/6706){: .external}
* {{changed}} Updated `protolite-well-known-types` dependency to `18.0.1`. GitHub [#6716](//github.com/firebase/firebase-android-sdk/issues/6716){: .external}
#### {{firestore}} Kotlin extensions version 25.1.3 {: #firestore-ktx_v25-1-3}
The Kotlin extensions library transitively includes the updated
`firebase-firestore` library. The Kotlin extensions library has no additional
updates.
|
Coverage Report 1Affected Products
Test Logs |
Test Results 186 files - 848 186 suites - 848 4m 42s ⏱️ - 29m 31s Results for commit 629b394. ± Comparison against base commit ad7618b. This pull request removes 4657 and adds 1 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
Size Report 1Affected Products
Test Logs |
The previous fix created a performance issue due to expensive UTF-8 encoding. Update
compareUtf8Strings
to use lazy encoding instead.