Skip to content

Remove D/FirebaseCrashlytics prefix from logs #1247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 14, 2020
Merged

Remove D/FirebaseCrashlytics prefix from logs #1247

merged 1 commit into from
Feb 14, 2020

Conversation

mrwillis21
Copy link
Contributor

Previously, this could be overridden by end users, but the
override has been removed, rendering this prefix superfluous.

@mrwillis21
Remove D/FirebaseCrashlytics prefix from logs
3e5f808 
Previously, this could be overridden by end users, but the
override has been removed, rendering this prefix superfluous.
@googlebot googlebot added the cla: yes Override cla label Feb 14, 2020
@codecov
Copy link

codecov bot commented Feb 14, 2020 •
edited
Loading

Codecov Report

Merging #1247 into master will decrease coverage by 46.95%.
The diff coverage is 0%.

Flag Coverage Δ Complexity Δ
#Encoders_FirebaseEncodersJson ? ?
#Encoders_FirebaseEncodersProcessor ? ?
#Encoders_FirebaseEncodersReflective ? ?
#FirebaseAbt ? ?
#FirebaseCommon ? ?
#FirebaseCommon_DataCollectionTests ? ?
#FirebaseCommon_Ktx ? ?
#FirebaseComponents ? ?
#FirebaseConfig ? ?
#FirebaseConfig_Ktx ? ?
#FirebaseCrashlytics 7.62% <0%> (-92.38%) 72 <0> (+72)
#FirebaseDatabase ? ?
#FirebaseDatabaseCollection ? ?
#FirebaseDatabase_Ktx ? ?
#FirebaseDatatransport ? ?
#FirebaseDynamicLinks ? ?
#FirebaseDynamicLinks_Ktx ? ?
#FirebaseFirestore ? ?
#FirebaseFirestore_Ktx ? ?
#FirebaseFunctions ? ?
#FirebaseFunctions_Ktx ? ?
#FirebaseInappmessaging ? ?
#FirebaseInappmessagingDisplay ? ?
#FirebaseInappmessagingDisplay_Ktx ? ?
#FirebaseInappmessaging_Ktx ? ?
#FirebaseInstallations ? ?
#FirebaseSegmentation ? ?
#FirebaseStorage ? ?
#FirebaseStorage_Ktx ? ?
#Tools_Errorprone ? ?
#Tools_Lint ? ?
#Transport_TransportBackendCct ? ?
#Transport_TransportRuntime ? ?

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 244b739...3e5f808. Read the comment docs.

mrichards
mrichards approved these changes Feb 14, 2020
View reviewed changes
Copy link
Contributor

@mrichards mrichards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Are we updating firebase-crashlytics/CHANGELOG.md as we go, or during releases? I don't see it being used consistently across firebase but it may be nice to add an Unreleased section now so we don't need to later? IDK.

@mrwillis21
Copy link
Contributor Author

Chatted about the changelog offline, decided against it.

@mrwillis21 mrwillis21 merged commit 73c0132 into master Feb 14, 2020
@mrwillis21 mrwillis21 deleted the remove-crashlytics-log-prefix branch February 14, 2020 21:52
@aguatno aguatno mentioned this pull request Feb 19, 2020
Closed
@firebase firebase locked and limited conversation to collaborators Mar 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mrichards mrichards mrichards approved these changes

Assignees
No one assigned
Labels
cla: yes Override cla size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mrwillis21 @mrichards @googlebot @google-oss-bot