Check for user ID file before trying to read it #1635
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The user ID file will be missing if no user ID was set, so check if it exists before trying to read from it to avoid unnecessary error logging. Fixes one of the prevalent issues in #1559
Coverage ReportAffected SDKsNo changes between base commit (dac28c4) and head commit (861362e7). Test Logs
NotesHTML coverage reports can be produced locally with Head commit (861362e7) is created by Prow via merging commits: dac28c4 88f1dd1. |
Binary Size ReportAffected SDKs
Test Logs
NotesHead commit (861362e7) is created by Prow via merging commits: dac28c4 88f1dd1. |
|
/test smoke-tests |
mrichards
approved these changes
Jun 10, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The user ID file will be missing if no user ID was set, so check
if it exists before trying to read from it to avoid unnecessary
error logging.
Fixes one of the prevalent issues in
#1559