New class and methods to implement bulk custom key/value logging. #2443

elenadoty · 2021-02-16T18:44:24Z

Bulk key/value logging reduces the computational overhead of logging multiple custom keys and values all at once by caching all pairs at once rather than individually.

google-oss-bot · 2021-02-16T18:48:57Z

Coverage Report

Affected SDKs

firebase-crashlytics

SDK overall coverage did not change between base commit (f56a977) and head commit (3edf992a). However there are changes in individual files.

Filename Base (f56a977) Head (3edf992a) Diff

CustomKeysAndValues.java ? 0.00% ?

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (3edf992a) is created by Prow via merging commits: f56a977 904ff7e.

google-oss-bot · 2021-02-16T18:50:05Z

The public api surface has changed for the subproject firebase-crashlytics:
error: Added class com.google.firebase.crashlytics.CustomKeysAndValues [AddedClass]
error: Removed method com.google.firebase.crashlytics.FirebaseCrashlytics.setCustomKeys(CustomKeysAndValues) [RemovedMethod]
error: Added method com.google.firebase.crashlytics.FirebaseCrashlytics.setCustomKeys(com.google.firebase.crashlytics.CustomKeysAndValues) [AddedMethod]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

google-oss-bot · 2021-02-16T18:56:02Z

Binary Size Report

Affected SDKs

firebase-crashlytics

Type Base (f56a977) Head (3edf992a) Diff

aar 322 kB 325 kB +3.16 kB (+1.0%)

apk (aggressive) 192 kB 192 kB -24 B (-0.0%)

apk (release) 817 kB 818 kB +756 B (+0.1%)

Test Logs

Notes

Head commit (3edf992a) is created by Prow via merging commits: f56a977 904ff7e.

google-oss-bot · 2021-02-16T19:00:29Z

The public api surface has changed for the subproject firebase-crashlytics:
error: Added class com.google.firebase.crashlytics.CustomKeysAndValues [AddedClass]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

google-oss-bot · 2021-02-16T19:21:53Z

The public api surface has changed for the subproject firebase-crashlytics:
error: Added class com.google.firebase.crashlytics.CustomKeysAndValues [AddedClass]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

elenadoty · 2021-02-16T19:23:14Z

/retest

google-oss-bot · 2021-02-16T19:28:26Z

The public api surface has changed for the subproject firebase-crashlytics:
error: Added class com.google.firebase.crashlytics.CustomKeysAndValues [AddedClass]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

google-oss-bot · 2021-02-16T19:31:55Z

The public api surface has changed for the subproject firebase-crashlytics:
error: Added class com.google.firebase.crashlytics.CustomKeysAndValues [AddedClass]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

google-oss-bot · 2021-02-16T19:41:17Z

The public api surface has changed for the subproject firebase-crashlytics:
error: Added class com.google.firebase.crashlytics.CustomKeysAndValues [AddedClass]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

google-oss-bot · 2021-02-16T19:56:33Z

The public api surface has changed for the subproject firebase-crashlytics:
error: Added class com.google.firebase.crashlytics.CustomKeysAndValues [AddedClass]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

google-oss-bot · 2021-02-16T20:24:21Z

The public api surface has changed for the subproject firebase-crashlytics:
error: Added class com.google.firebase.crashlytics.CustomKeysAndValues [AddedClass]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

samedson · 2021-02-17T16:32:39Z

firebase-crashlytics/src/main/java/com/google/firebase/crashlytics/CustomKeysAndValues.java

+  }
+
+  @NonNull
+  public Map<String, String> getCustomValues() {


Is there a way to keep this private from customers?

Agreed, I don't think we should have a getter here, since we don't have a getter for the single-value case (also there wasn't one in the API review).

google-oss-bot · 2021-02-17T18:23:06Z

The public api surface has changed for the subproject firebase-crashlytics:
error: Removed method com.google.firebase.crashlytics.CustomKeysAndValues.getCustomValues() [RemovedMethod]
error: Added field com.google.firebase.crashlytics.CustomKeysAndValues.keysAndValues [AddedField]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

google-oss-bot · 2021-02-17T18:34:20Z

The public api surface has changed for the subproject firebase-crashlytics:
error: Added field com.google.firebase.crashlytics.CustomKeysAndValues.keysAndValues [AddedField]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

google-oss-bot · 2021-02-17T18:47:40Z

The public api surface has changed for the subproject firebase-crashlytics:
error: Field com.google.firebase.crashlytics.CustomKeysAndValues.keysAndValues changed visibility from protected to public [ChangedScope]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

firebase-crashlytics/src/main/java/com/google/firebase/crashlytics/CustomKeysAndValues.java

...-crashlytics/src/main/java/com/google/firebase/crashlytics/internal/common/UserMetadata.java

google-oss-bot · 2021-02-17T19:06:56Z

The public api surface has changed for the subproject firebase-crashlytics:
error: Removed constructor com.google.firebase.crashlytics.CustomKeysAndValues(com.google.firebase.crashlytics.CustomKeysAndValues.Builder) [RemovedMethod]
error: Removed field com.google.firebase.crashlytics.CustomKeysAndValues.keysAndValues [RemovedField]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

elenadoty · 2021-02-19T21:36:07Z

/retest

elenadoty added 5 commits February 16, 2021 12:58

New class and methods to implement bulk key/value logging

c781444

Use assertTrue instead of assertEquals

fb92ec4

fix formatting

4d2d960

Use delta in comparison of numbers

aaf8e81

Fix tests

76b3197

googlebot added the cla: yes Override cla label Feb 16, 2021

google-oss-bot added the size/L label Feb 16, 2021

Update api.txt with full name of custom class

54e00ad

elenadoty added 3 commits February 16, 2021 14:15

Use Boolean.valueOf instead of Boolean.parseBoolean

a33d5d0

Updated CHANGELOG

5ee392d

Updated CHANGELOG

5ae1deb

Don't convert booleans in tests

cf30c96

Failing assert

4ac90da

elenadoty added 2 commits February 16, 2021 15:06

Fix assert statements

2d9280e

Class is public

ff2c5c0

elenadoty added 4 commits February 16, 2021 15:28

update api.txt

3d84e03

update test asserts

5b57ba5

update api.txt in NDK directory

ef9e8c1

Update test comments

b94ce23

update tests

bb51c7d

elenadoty requested review from mrichards and mrwillis21 February 17, 2021 16:22

samedson reviewed Feb 17, 2021

View reviewed changes

Remove getter method and refactor UserMetadata

d3c8660

update api.txt

1e90c6c

elenadoty added 2 commits February 17, 2021 13:39

fix api.txt

6badc98

keysAndValues must be public

92dbc4d

update api.txt

556a5aa

mrwillis21 suggested changes Feb 17, 2021

View reviewed changes

Update access to methods/variables

87866af

elenadoty added 6 commits February 17, 2021 14:07

update api.txt

e5a9966

update tests to reflect private class

2d0b8a1

Refactor UserMetadata.java to fix race condition

154ec52

Add some of the dictionary if there isn't space for all of it

b107e23

Fix test for alphabetic sorting

9c4a76f

remove alphabetical sorting for new keys

9cf467a

elenadoty added 3 commits February 22, 2021 16:57

Update javadocs to reflect behavior of setCustomKeys

863dd10

Update CrashlyticsCore.java

1d12938

style

904ff7e

elenadoty requested a review from mrwillis21 February 24, 2021 16:55

mrwillis21 approved these changes Feb 25, 2021

View reviewed changes

elenadoty merged commit f394bd4 into master Feb 25, 2021

elenadoty deleted the bulk_kv branch February 25, 2021 18:14

firebase locked and limited conversation to collaborators Mar 28, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New class and methods to implement bulk custom key/value logging. #2443

New class and methods to implement bulk custom key/value logging. #2443

elenadoty commented Feb 16, 2021

google-oss-bot commented Feb 16, 2021 •

edited

Loading

`firebase-crashlytics`

google-oss-bot commented Feb 16, 2021

google-oss-bot commented Feb 16, 2021 •

edited

Loading

`firebase-crashlytics`

google-oss-bot commented Feb 16, 2021

google-oss-bot commented Feb 16, 2021

elenadoty commented Feb 16, 2021

google-oss-bot commented Feb 16, 2021

google-oss-bot commented Feb 16, 2021

google-oss-bot commented Feb 16, 2021

google-oss-bot commented Feb 16, 2021

google-oss-bot commented Feb 16, 2021

samedson Feb 17, 2021

mrwillis21 Feb 17, 2021 •

edited

Loading

google-oss-bot commented Feb 17, 2021

google-oss-bot commented Feb 17, 2021

google-oss-bot commented Feb 17, 2021

google-oss-bot commented Feb 17, 2021

elenadoty commented Feb 19, 2021

New class and methods to implement bulk custom key/value logging. #2443

New class and methods to implement bulk custom key/value logging. #2443

Conversation

elenadoty commented Feb 16, 2021

google-oss-bot commented Feb 16, 2021 • edited Loading

Coverage Report

Affected SDKs

firebase-crashlytics

Test Logs

Notes

google-oss-bot commented Feb 16, 2021

google-oss-bot commented Feb 16, 2021 • edited Loading

Binary Size Report

Affected SDKs

firebase-crashlytics

Test Logs

Notes

google-oss-bot commented Feb 16, 2021

google-oss-bot commented Feb 16, 2021

elenadoty commented Feb 16, 2021

google-oss-bot commented Feb 16, 2021

google-oss-bot commented Feb 16, 2021

google-oss-bot commented Feb 16, 2021

google-oss-bot commented Feb 16, 2021

google-oss-bot commented Feb 16, 2021

samedson Feb 17, 2021

Choose a reason for hiding this comment

mrwillis21 Feb 17, 2021 • edited Loading

Choose a reason for hiding this comment

google-oss-bot commented Feb 17, 2021

google-oss-bot commented Feb 17, 2021

google-oss-bot commented Feb 17, 2021

google-oss-bot commented Feb 17, 2021

elenadoty commented Feb 19, 2021

google-oss-bot commented Feb 16, 2021 •

edited

Loading

`firebase-crashlytics`

google-oss-bot commented Feb 16, 2021 •

edited

Loading

`firebase-crashlytics`

mrwillis21 Feb 17, 2021 •

edited

Loading