Skip to content

Pass "Locale-US" to SimpleDateFormat while formatting first-open time… #3877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 7, 2022
Merged

Pass "Locale-US" to SimpleDateFormat while formatting first-open time… #3877

merged 2 commits into from
Jul 7, 2022

Conversation

richaurora
Copy link
Contributor

@richaurora richaurora commented Jul 6, 2022 •
edited
Loading

…. This ensures that the english numerals in the timestamp are not converted to the local language numerals.

This is a fix for #3757. The issue was introduced in #3653

@richaurora
Pass "Locale-US" to SimpleDateFormat while formatting first-open time…
78f761e 
…. This ensures that the english numerals in the timestamp are not converted to the local language numerals.

This is a fix for #3757
@richaurora richaurora requested a review from danasilver July 6, 2022 23:23
@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2022 •
edited
Loading

Unit Test Results

1 204 tests  +1 204   1 204 ✔️ +1 204   2m 8s ⏱️ + 2m 8s
     61 suites +     61          0 💤 ±       0 
     61 files   +     61          0 ❌ ±       0 

Results for commit 0021bab. ± Comparison against base commit 1b5e956.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 6, 2022 •
edited
Loading

Coverage Report 1

Affected Products

No changes between base commit (1b5e956) and merge commit (e9dc39b).

Test Logs

Notes

  • Commit (e9dc39b) is created by Prow via merging PR base commit (1b5e956) and head commit (0021bab).
  • Run gradle <product>:checkCoverage to produce HTML coverage reports locally. After gradle commands finished, report files can be found under <product-build-dir>/reports/jacoco/.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/K7JDlxL3X0.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 6, 2022 •
edited
Loading

Size Report 1

Affected Products

  • firebase-config

    TypeBase (1b5e956)Merge (e9dc39b)Diff
    aar63.2 kB63.3 kB+28 B (+0.0%)
    apk (aggressive)94.2 kB94.2 kB+8 B (+0.0%)
    apk (release)743 kB743 kB-44 B (-0.0%)

Test Logs

Notes

  • Commit (e9dc39b) is created by Prow via merging PR base commit (1b5e956) and head commit (0021bab).

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/5qIGoWEbcs.html

@richaurora richaurora merged commit 939f90e into master Jul 7, 2022
@richaurora richaurora deleted the riora-fix-time-locale-format branch July 7, 2022 00:19
@thatfiredev thatfiredev mentioned this pull request Jul 14, 2022
Closed
@firebase firebase locked and limited conversation to collaborators Aug 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@danasilver danasilver danasilver approved these changes

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@richaurora @google-oss-bot @danasilver