Skip to content

Removing getRunningAppProcesses since the process_name isn't used #4057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 15, 2022
Merged

Removing getRunningAppProcesses since the process_name isn't used #4057

merged 1 commit into from
Sep 15, 2022

Conversation

raymondlam
Copy link
Member

getRunningAppProcesses() was also causing compliance issues with Tencent's appstore #4045

@raymondlam raymondlam force-pushed the removeGetRunningAppProcesses branch from 2730613 to d1e5c88 Compare September 3, 2022 00:27
@raymondlam
Copy link
Member Author

/retest

jeremyjiang-dev
jeremyjiang-dev approved these changes Sep 6, 2022
View reviewed changes
Copy link
Contributor

@jeremyjiang-dev jeremyjiang-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@jeremyjiang-dev
Copy link
Contributor

The failing unit test seems to be flaky

@raymondlam
Copy link
Member Author

/retest

visumickey
visumickey approved these changes Sep 8, 2022
View reviewed changes
Copy link
Contributor

@visumickey visumickey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making these changes!

@raymondlam
Copy link
Member Author

/retest

@raymondlam raymondlam force-pushed the removeGetRunningAppProcesses branch from d1e5c88 to 4cd15cc Compare September 15, 2022 19:48
@raymondlam raymondlam merged commit 6df92b9 into firebase:master Sep 15, 2022
qdpham13 pushed a commit that referenced this pull request Sep 20, 2022
@raymondlam @qdpham13
Removing getRunningAppProcesses since the process_name isn't used (#4057
aaf97e2 
)
@raymondlam raymondlam deleted the removeGetRunningAppProcesses branch October 11, 2022 16:50
@firebase firebase locked and limited conversation to collaborators Oct 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@visumickey visumickey visumickey approved these changes

@jeremyjiang-dev jeremyjiang-dev jeremyjiang-dev approved these changes

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@raymondlam @jeremyjiang-dev @visumickey @google-oss-bot