Make FiresiteTransform a Cacheable task #4124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vkryachko
approved these changes
Sep 21, 2022
buildSrc/src/main/java/com/google/firebase/gradle/plugins/FiresiteTransformTask.kt
Show resolved
Hide resolved
Size Report 1Affected ProductsNo changes between base commit (523730a) and merge commit (9329f39).Test Logs |
Coverage Report 1Affected Products
Test Logs |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an effort to make the DackkaPlugin tasks all cache compliant (per b/243833009), the only remaining task that was not already cache complaint was FiresiteTransform. This PR fixes that.
More specifically, we now copy the transformed files into a new directory labeled
dackkaTransformedFiles, versus working on the same files that Dackka outputs. This allows gradle to check if the files have actually changed, and pass anUP-TO-DATE-CHECKas needed.Build time has dropped from ~50 seconds to only ~15 seconds, that's a 333% decrease!