Skip to content

Update CHANGELOG entries across several sdks #4240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 29, 2022
Merged

Update CHANGELOG entries across several sdks #4240

merged 1 commit into from
Oct 29, 2022

Conversation

rlazo
Copy link
Collaborator

@rlazo rlazo commented Oct 25, 2022

No description provided.

@rlazo rlazo requested review from vkryachko and daymxn October 25, 2022 16:50
@github-actions
Copy link
Contributor

Unit Test Results

   175 files  +     96     175 suites  +96   7m 30s ⏱️ + 6m 33s
2 409 tests +1 312  2 393 ✔️ +1 312  16 💤 ±0  0 ❌ ±0 
2 413 runs  +1 316  2 397 ✔️ +1 316  16 💤 ±0  0 ❌ ±0 

Results for commit bdd7cc3. ± Comparison against base commit ae3bdb8.

@google-oss-bot
Copy link
Contributor

Coverage Report 1

This report is too large (76,790 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/Nwe7BQPPvF.html

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

No changes between base commit (ae3bdb8) and merge commit (92af3da).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/2nkaRvLXnN.html

@rlazo
Copy link
Collaborator Author

rlazo commented Oct 26, 2022

friendly ping

daymxn
daymxn reviewed Oct 27, 2022
View reviewed changes
firebase-crashlytics-ndk/CHANGELOG.md
@@ -1,7 +1,15 @@
# Unreleased
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's this for?

daymxn
daymxn reviewed Oct 27, 2022
View reviewed changes
firebase-ml-modeldownloader/CHANGELOG.md
* [fixed] Fixed an issue where `FirebaseModelDownloader.getModel` was throwing
`FirebaseMlException.PERMISSION_DENIED` when the model name was empty. It now
throws `FirebaseMlException.INVALID_ARGUMENT`
(#4157)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these also supposed to be links btw?

daymxn
daymxn approved these changes Oct 27, 2022
View reviewed changes
Copy link
Member

@daymxn daymxn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although would you mind pinging me in gc with the tooling that interprets this?

@rlazo rlazo merged commit ffca832 into master Oct 29, 2022
@rlazo rlazo deleted the rl.changeup771 branch October 29, 2022 02:06
@firebase firebase locked and limited conversation to collaborators Nov 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@daymxn daymxn daymxn approved these changes

@vkryachko vkryachko Awaiting requested review from vkryachko

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rlazo @google-oss-bot @daymxn