Register executors as components. #4288
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
Coverage Report 1Affected Products
Test Logs |
Size Report 1Affected Products
Test Logs |
0c4e05b to
99789c1
Compare
The intent for those is to be used by all Firebase SDKs and forbid creating their own at will.
99789c1 to
c030bbc
Compare
vkryachko
commented
Nov 9, 2022
firebase-common/src/main/java/com/google/firebase/heartbeatinfo/DefaultHeartBeatController.java
Show resolved
Hide resolved
rlazo
reviewed
Nov 9, 2022
firebase-annotations/src/main/java/com/google/firebase/annotations/concurrent/Background.java
Show resolved
Hide resolved
firebase-annotations/src/main/java/com/google/firebase/annotations/concurrent/Lightweight.java
Outdated
Show resolved
Hide resolved
|
|
||
| class CustomThreadFactory implements ThreadFactory { | ||
| private static final ThreadFactory DEFAULT = Executors.defaultThreadFactory(); | ||
| private final AtomicLong threadCount = new AtomicLong(); |
There was a problem hiding this comment.
This is common practice to give different names to threads, i.e. executor-foo-1, executor-foo-2 etc.
There was a problem hiding this comment.
Didn't see it in the name, thanks!
rlazo
approved these changes
Nov 10, 2022
vkryachko
added a commit
that referenced
this pull request
Nov 15, 2022
* Add qualifier support to firebase components. (#3180) * Add qualifier support to firebase components. Details: go/firebase-component-qualifiers * fix errorprone error. * change copyright year. * Register executors as components. (#4288) * Register executors as components. The intent for those is to be used by all Firebase SDKs and forbid creating their own at will. * Add copyrights. * add more copyrights * ktlintformat * gJF * ktlint * Address review comments. * Adds generally useful executors (#4305) Namely, SequentialExecutor and directExecutor. * Enable strict mode for executors. (#4303) Any violations would kill the app in debug builds of firebase-common, and log a warning in release builds. This is done to fail tests that incorrectly use executors while not affecting 3p apps in release builds. Additionally correctly set thread priorities in an Android specific way. * Enable thread pool linter check. (#4297) * Enable thread pool linter check. All violations are now suppressed, bugs filed to fix each product. * ktlint * Remove init * Fix copyright
davidmotson
pushed a commit
that referenced
this pull request
Nov 28, 2022
* Add qualifier support to firebase components. (#3180) * Add qualifier support to firebase components. Details: go/firebase-component-qualifiers * fix errorprone error. * change copyright year. * Register executors as components. (#4288) * Register executors as components. The intent for those is to be used by all Firebase SDKs and forbid creating their own at will. * Add copyrights. * add more copyrights * ktlintformat * gJF * ktlint * Address review comments. * Adds generally useful executors (#4305) Namely, SequentialExecutor and directExecutor. * Enable strict mode for executors. (#4303) Any violations would kill the app in debug builds of firebase-common, and log a warning in release builds. This is done to fail tests that incorrectly use executors while not affecting 3p apps in release builds. Additionally correctly set thread priorities in an Android specific way. * Enable thread pool linter check. (#4297) * Enable thread pool linter check. All violations are now suppressed, bugs filed to fix each product. * ktlint * Remove init * Fix copyright
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The intent for those is to be used by all Firebase SDKs and forbid creating their own at will.