Switch from ktlint to ktfmt #4318

vkryachko · 2022-11-14T17:22:13Z

Additionally upgrade google-java-format to latest version.

google-oss-bot · 2022-11-14T17:22:43Z

	1 Warning
⚠️	Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

github-actions · 2022-11-14T17:26:42Z

buildSrc Test Results

18 tests 18 ✔️ 1m 25s ⏱️
  4 suites   0 💤
  4 files   0 ❌

Results for commit 9a6a908.

google-oss-bot · 2022-11-14T17:47:07Z

Size Report ¹

Affected Products

base
Type Base (d4cc84d) Merge (1d31669) Diff
apk (aggressive) ? 8.39 kB ? (?)
apk (release) ? 8.65 kB ? (?)
firebase-abt
Type Base (d4cc84d) Merge (1d31669) Diff
aar ? 13.8 kB ? (?)
apk (aggressive) ? 85.8 kB ? (?)
apk (release) ? 688 kB ? (?)
firebase-annotations
Type Base (d4cc84d) Merge (1d31669) Diff
apk (aggressive) ? 8.39 kB ? (?)
apk (release) ? 8.89 kB ? (?)
firebase-appcheck
Type Base (d4cc84d) Merge (1d31669) Diff
aar ? 37.6 kB ? (?)
apk (aggressive) ? 332 kB ? (?)
apk (release) ? 978 kB ? (?)
firebase-appcheck-debug
Type Base (d4cc84d) Merge (1d31669) Diff
aar ? 11.6 kB ? (?)
apk (aggressive) ? 332 kB ? (?)
apk (release) ? 980 kB ? (?)
firebase-appcheck-debug-testing
Type Base (d4cc84d) Merge (1d31669) Diff
aar ? 6.26 kB ? (?)
apk (aggressive) ? 334 kB ? (?)
apk (release) ? 1.02 MB ? (?)
firebase-appcheck-interop
Type Base (d4cc84d) Merge (1d31669) Diff
aar ? 5.02 kB ? (?)
apk (aggressive) ? 329 kB ? (?)
apk (release) ? 966 kB ? (?)
firebase-appcheck-ktx
Type Base (d4cc84d) Merge (1d31669) Diff
aar ? 5.98 kB ? (?)
apk (aggressive) ? 356 kB ? (?)
apk (release) ? 1.92 MB ? (?)
firebase-appcheck-playintegrity
Type Base (d4cc84d) Merge (1d31669) Diff
aar ? 10.1 kB ? (?)
apk (aggressive) ? 332 kB ? (?)
apk (release) ? 991 kB ? (?)
firebase-appcheck-safetynet
Type Base (d4cc84d) Merge (1d31669) Diff
aar ? 12.1 kB ? (?)
apk (aggressive) ? 332 kB ? (?)
apk (release) ? 992 kB ? (?)
firebase-appdistribution
Type Base (d4cc84d) Merge (1d31669) Diff
aar ? 140 kB ? (?)
apk (aggressive) ? 777 kB ? (?)
apk (release) ? 2.00 MB ? (?)
firebase-appdistribution-api
Type Base (d4cc84d) Merge (1d31669) Diff
aar ? 14.2 kB ? (?)
apk (aggressive) ? 85.8 kB ? (?)
apk (release) ? 689 kB ? (?)
firebase-appdistribution-api-ktx
Type Base (d4cc84d) Merge (1d31669) Diff
aar ? 5.83 kB ? (?)
apk (aggressive) ? 110 kB ? (?)
apk (release) ? 1.63 MB ? (?)
firebase-common
Type Base (d4cc84d) Merge (1d31669) Diff
aar ? 50.1 kB ? (?)
apk (aggressive) ? 85.1 kB ? (?)
apk (release) ? 683 kB ? (?)
firebase-common-ktx
Type Base (d4cc84d) Merge (1d31669) Diff
aar ? 6.02 kB ? (?)
apk (aggressive) ? 109 kB ? (?)
apk (release) ? 1.62 MB ? (?)
firebase-components
Type Base (d4cc84d) Merge (1d31669) Diff
aar ? 42.8 kB ? (?)
apk (aggressive) ? 8.68 kB ? (?)
apk (release) ? 31.9 kB ? (?)
firebase-config
Type Base (d4cc84d) Merge (1d31669) Diff
aar ? 63.0 kB ? (?)
apk (aggressive) ? 94.4 kB ? (?)
apk (release) ? 736 kB ? (?)
firebase-config-ktx
Type Base (d4cc84d) Merge (1d31669) Diff
aar ? 5.58 kB ? (?)
apk (aggressive) ? 119 kB ? (?)
apk (release) ? 1.67 MB ? (?)
firebase-crashlytics
Type Base (d4cc84d) Merge (1d31669) Diff
aar ? 341 kB ? (?)
apk (aggressive) ? 217 kB ? (?)
apk (release) ? 896 kB ? (?)
firebase-crashlytics-ktx
Type Base (d4cc84d) Merge (1d31669) Diff
aar ? 6.57 kB ? (?)
apk (aggressive) ? 237 kB ? (?)
apk (release) ? 1.83 MB ? (?)

`firebase-crashlytics-ndk`

Type	Base (`d4cc84d`)	Merge (`1d31669`)	Diff
aar	?	1.68 MB	? (?)
apk (aggressive / arm64-v8a)	?	1.34 MB	? (?)
apk (aggressive / armeabi-v7a)	?	846 kB	? (?)
apk (aggressive / x86)	?	1.38 MB	? (?)
apk (aggressive / x86_64)	?	1.45 MB	? (?)
apk (release / arm64-v8a)	?	2.02 MB	? (?)
apk (release / armeabi-v7a)	?	1.52 MB	? (?)
apk (release / x86)	?	2.06 MB	? (?)
apk (release / x86_64)	?	2.12 MB	? (?)

firebase-database
Type Base (d4cc84d) Merge (1d31669) Diff
aar ? 488 kB ? (?)
apk (aggressive) ? 330 kB ? (?)
apk (release) ? 1.14 MB ? (?)
firebase-database-collection
Type Base (d4cc84d) Merge (1d31669) Diff
aar ? 33.6 kB ? (?)
apk (aggressive) ? 312 kB ? (?)
apk (release) ? 941 kB ? (?)
firebase-database-ktx
Type Base (d4cc84d) Merge (1d31669) Diff
aar ? 22.5 kB ? (?)
apk (aggressive) ? 354 kB ? (?)
apk (release) ? 2.08 MB ? (?)
firebase-datatransport
Type Base (d4cc84d) Merge (1d31669) Diff
aar ? 4.94 kB ? (?)
apk (aggressive) ? 136 kB ? (?)
apk (release) ? 771 kB ? (?)
firebase-decoders-json
Type Base (d4cc84d) Merge (1d31669) Diff
aar ? 7.67 kB ? (?)
apk (aggressive) ? 8.68 kB ? (?)
apk (release) ? 15.3 kB ? (?)
firebase-dynamic-links
Type Base (d4cc84d) Merge (1d31669) Diff
aar ? 54.6 kB ? (?)
apk (aggressive) ? 331 kB ? (?)
apk (release) ? 979 kB ? (?)
firebase-dynamic-links-ktx
Type Base (d4cc84d) Merge (1d31669) Diff
aar ? 8.28 kB ? (?)
apk (aggressive) ? 355 kB ? (?)
apk (release) ? 1.92 MB ? (?)
firebase-dynamic-module-support
Type Base (d4cc84d) Merge (1d31669) Diff
aar ? 5.67 kB ? (?)
apk (aggressive) ? 94.3 kB ? (?)
apk (release) ? 735 kB ? (?)
firebase-encoders
Type Base (d4cc84d) Merge (1d31669) Diff
apk (aggressive) ? 8.68 kB ? (?)
apk (release) ? 15.3 kB ? (?)
firebase-encoders-json
Type Base (d4cc84d) Merge (1d31669) Diff
aar ? 10.7 kB ? (?)
apk (aggressive) ? 8.68 kB ? (?)
apk (release) ? 20.1 kB ? (?)
firebase-encoders-proto
Type Base (d4cc84d) Merge (1d31669) Diff
apk (aggressive) ? 8.68 kB ? (?)
apk (release) ? 21.6 kB ? (?)
firebase-encoders-reflective
Type Base (d4cc84d) Merge (1d31669) Diff
aar ? 7.80 kB ? (?)
apk (aggressive) ? 8.68 kB ? (?)
apk (release) ? 22.2 kB ? (?)
firebase-firestore
Type Base (d4cc84d) Merge (1d31669) Diff
aar ? 1.31 MB ? (?)
apk (aggressive) ? 492 kB ? (?)
apk (release) ? 3.35 MB ? (?)
firebase-firestore-ktx
Type Base (d4cc84d) Merge (1d31669) Diff
aar ? 13.5 kB ? (?)
apk (aggressive) ? 512 kB ? (?)
apk (release) ? 4.29 MB ? (?)
firebase-functions
Type Base (d4cc84d) Merge (1d31669) Diff
aar ? 25.8 kB ? (?)
apk (aggressive) ? 375 kB ? (?)
apk (release) ? 1.23 MB ? (?)
firebase-functions-ktx
Type Base (d4cc84d) Merge (1d31669) Diff
aar ? 5.69 kB ? (?)
apk (aggressive) ? 395 kB ? (?)
apk (release) ? 2.17 MB ? (?)
firebase-inappmessaging
Type Base (d4cc84d) Merge (1d31669) Diff
aar ? 470 kB ? (?)
apk (aggressive) ? 673 kB ? (?)
apk (release) ? 3.38 MB ? (?)
firebase-inappmessaging-display
Type Base (d4cc84d) Merge (1d31669) Diff
aar ? 201 kB ? (?)
apk (aggressive) ? 1.51 MB ? (?)
apk (release) ? 4.64 MB ? (?)
firebase-inappmessaging-display-ktx
Type Base (d4cc84d) Merge (1d31669) Diff
aar ? 17.6 kB ? (?)
apk (aggressive) ? 1.53 MB ? (?)
apk (release) ? 5.58 MB ? (?)
firebase-inappmessaging-ktx
Type Base (d4cc84d) Merge (1d31669) Diff
aar ? 5.03 kB ? (?)
apk (aggressive) ? 694 kB ? (?)
apk (release) ? 4.31 MB ? (?)
firebase-installations
Type Base (d4cc84d) Merge (1d31669) Diff
aar ? 54.9 kB ? (?)
apk (aggressive) ? 86.5 kB ? (?)
apk (release) ? 706 kB ? (?)
firebase-installations-interop
Type Base (d4cc84d) Merge (1d31669) Diff
aar ? 8.05 kB ? (?)
apk (aggressive) ? 65.0 kB ? (?)
apk (release) ? 651 kB ? (?)
firebase-installations-ktx
Type Base (d4cc84d) Merge (1d31669) Diff
aar ? 5.00 kB ? (?)
apk (aggressive) ? 111 kB ? (?)
apk (release) ? 1.64 MB ? (?)
firebase-messaging
Type Base (d4cc84d) Merge (1d31669) Diff
aar ? 142 kB ? (?)
apk (aggressive) ? 440 kB ? (?)
apk (release) ? 1.14 MB ? (?)
firebase-messaging-directboot
Type Base (d4cc84d) Merge (1d31669) Diff
aar ? 8.75 kB ? (?)
apk (aggressive) ? 440 kB ? (?)
apk (release) ? 1.14 MB ? (?)
firebase-messaging-ktx
Type Base (d4cc84d) Merge (1d31669) Diff
aar ? 6.10 kB ? (?)
apk (aggressive) ? 460 kB ? (?)
apk (release) ? 2.08 MB ? (?)
firebase-ml-modeldownloader
Type Base (d4cc84d) Merge (1d31669) Diff
aar ? 87.5 kB ? (?)
apk (aggressive) ? 143 kB ? (?)
apk (release) ? 823 kB ? (?)
firebase-ml-modeldownloader-ktx
Type Base (d4cc84d) Merge (1d31669) Diff
aar ? 6.10 kB ? (?)
apk (aggressive) ? 163 kB ? (?)
apk (release) ? 1.76 MB ? (?)
firebase-perf
Type Base (d4cc84d) Merge (1d31669) Diff
aar ? 313 kB ? (?)
apk (aggressive) ? 1.03 MB ? (?)
apk (release) ? 2.48 MB ? (?)
firebase-perf-ktx
Type Base (d4cc84d) Merge (1d31669) Diff
aar ? 16.0 kB ? (?)
apk (aggressive) ? 1.05 MB ? (?)
apk (release) ? 3.41 MB ? (?)
firebase-segmentation
Type Base (d4cc84d) Merge (1d31669) Diff
aar ? 20.0 kB ? (?)
apk (aggressive) ? 87.1 kB ? (?)
apk (release) ? 712 kB ? (?)
firebase-storage
Type Base (d4cc84d) Merge (1d31669) Diff
aar ? 116 kB ? (?)
apk (aggressive) ? 330 kB ? (?)
apk (release) ? 1.01 MB ? (?)
firebase-storage-ktx
Type Base (d4cc84d) Merge (1d31669) Diff
aar ? 13.1 kB ? (?)
apk (aggressive) ? 354 kB ? (?)
apk (release) ? 1.95 MB ? (?)
protolite-well-known-types
Type Base (d4cc84d) Merge (1d31669) Diff
aar ? 999 kB ? (?)
apk (aggressive) ? 134 kB ? (?)
apk (release) ? 663 kB ? (?)
transport-api
Type Base (d4cc84d) Merge (1d31669) Diff
aar ? 6.74 kB ? (?)
apk (aggressive) ? 8.68 kB ? (?)
apk (release) ? 14.9 kB ? (?)
transport-backend-cct
Type Base (d4cc84d) Merge (1d31669) Diff
aar ? 53.6 kB ? (?)
apk (aggressive) ? 58.2 kB ? (?)
apk (release) ? 105 kB ? (?)
transport-runtime
Type Base (d4cc84d) Merge (1d31669) Diff
aar ? 180 kB ? (?)
apk (aggressive) ? 44.0 kB ? (?)
apk (release) ? 83.5 kB ? (?)

Test Logs

Merge (1d31669): https://github.com/firebase/firebase-android-sdk/actions/runs/3463696195

https://storage.googleapis.com/firebase-sdk-metric-reports/HsIwoeMyHN.html

github-actions · 2022-11-14T17:48:37Z

Unit Test Results

  395 files   395 suites 19m 56s ⏱️
4 730 tests 4 708 ✔️ 22 💤 0 ❌
4 746 runs 4 724 ✔️ 22 💤 0 ❌

Results for commit 9a6a908.

♻️ This comment has been updated with latest results.

daymxn

Lets go!!! 🚀 🙏

Additionally upgrade google-java-format to latest version.

Switch from ktlint to ktfmt

9a6a908

Additionally upgrade google-java-format to latest version.

vkryachko requested a review from daymxn November 14, 2022 17:22

google-oss-bot added the size/XXL label Nov 14, 2022

daymxn approved these changes Nov 14, 2022

View reviewed changes

vkryachko merged commit c1adf5b into master Nov 14, 2022

vkryachko deleted the vk.tooling_upgrade branch November 14, 2022 18:10

davidmotson pushed a commit that referenced this pull request Nov 28, 2022

Switch from ktlint to ktfmt (#4318)

53efe73

Additionally upgrade google-java-format to latest version.

firebase locked and limited conversation to collaborators Dec 15, 2022

Switch from ktlint to ktfmt #4318

Switch from ktlint to ktfmt #4318

Conversation

vkryachko commented Nov 14, 2022

google-oss-bot commented Nov 14, 2022

github-actions bot commented Nov 14, 2022

buildSrc Test Results

google-oss-bot commented Nov 14, 2022

Size Report 1

Affected Products

base

firebase-abt

firebase-annotations

firebase-appcheck

firebase-appcheck-debug

firebase-appcheck-debug-testing

firebase-appcheck-interop

firebase-appcheck-ktx

firebase-appcheck-playintegrity

firebase-appcheck-safetynet

firebase-appdistribution

firebase-appdistribution-api

firebase-appdistribution-api-ktx

firebase-common

firebase-common-ktx

firebase-components

firebase-config

firebase-config-ktx

firebase-crashlytics

firebase-crashlytics-ktx

firebase-crashlytics-ndk

firebase-database

firebase-database-collection

firebase-database-ktx

firebase-datatransport

firebase-decoders-json

firebase-dynamic-links

firebase-dynamic-links-ktx

firebase-dynamic-module-support

firebase-encoders

firebase-encoders-json

firebase-encoders-proto

firebase-encoders-reflective

firebase-firestore

firebase-firestore-ktx

firebase-functions

firebase-functions-ktx

firebase-inappmessaging

firebase-inappmessaging-display

firebase-inappmessaging-display-ktx

firebase-inappmessaging-ktx

firebase-installations

firebase-installations-interop

firebase-installations-ktx

firebase-messaging

firebase-messaging-directboot

firebase-messaging-ktx

firebase-ml-modeldownloader

firebase-ml-modeldownloader-ktx

firebase-perf

firebase-perf-ktx

firebase-segmentation

firebase-storage

firebase-storage-ktx

protolite-well-known-types

transport-api

transport-backend-cct

transport-runtime

Test Logs

github-actions bot commented Nov 14, 2022 • edited Loading

Unit Test Results

daymxn left a comment

Choose a reason for hiding this comment

Size Report ¹

`base`

`firebase-abt`

`firebase-annotations`

`firebase-appcheck`

`firebase-appcheck-debug`

`firebase-appcheck-debug-testing`

`firebase-appcheck-interop`

`firebase-appcheck-ktx`

`firebase-appcheck-playintegrity`

`firebase-appcheck-safetynet`

`firebase-appdistribution`

`firebase-appdistribution-api`

`firebase-appdistribution-api-ktx`

`firebase-common`

`firebase-common-ktx`

`firebase-components`

`firebase-config`

`firebase-config-ktx`

`firebase-crashlytics`

`firebase-crashlytics-ktx`

`firebase-crashlytics-ndk`

`firebase-database`

`firebase-database-collection`

`firebase-database-ktx`

`firebase-datatransport`

`firebase-decoders-json`

`firebase-dynamic-links`

`firebase-dynamic-links-ktx`

`firebase-dynamic-module-support`

`firebase-encoders`

`firebase-encoders-json`

`firebase-encoders-proto`

`firebase-encoders-reflective`

`firebase-firestore`

`firebase-firestore-ktx`

`firebase-functions`

`firebase-functions-ktx`

`firebase-inappmessaging`

`firebase-inappmessaging-display`

`firebase-inappmessaging-display-ktx`

`firebase-inappmessaging-ktx`

`firebase-installations`

`firebase-installations-interop`

`firebase-installations-ktx`

`firebase-messaging`

`firebase-messaging-directboot`

`firebase-messaging-ktx`

`firebase-ml-modeldownloader`

`firebase-ml-modeldownloader-ktx`

`firebase-perf`

`firebase-perf-ktx`

`firebase-segmentation`

`firebase-storage`

`firebase-storage-ktx`

`protolite-well-known-types`

`transport-api`

`transport-backend-cct`

`transport-runtime`

github-actions bot commented Nov 14, 2022 •

edited

Loading