Fiam crash fix #4691

eldhosembabu · 2023-02-16T22:56:10Z

Crash fix: Attempt to invoke virtual method 'com.google.firebase.inappmessaging.model.MessageType kb.i.c()'

Added a null check to avoid the crash.

github-actions · 2023-02-16T22:56:27Z

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

Add the 'main-merge-ack' label to your PR to confirm merging into the main branch is intended.

google-oss-bot · 2023-02-16T22:56:42Z

	1 Warning
⚠️	Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

google-oss-bot · 2023-02-16T23:03:37Z

Coverage Report ¹

Affected Products

No changes between base commit (0c1240e) and merge commit (96bcc51).

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/sqrLGAYs3f.html

github-actions · 2023-02-16T23:06:16Z

Unit Test Results

47 tests - 427 46 ✔️ - 428 28s ⏱️ - 3m 5s
  6 suites -   21   1 💤 +    1
  6 files -   21   0 ❌ ±    0

Results for commit c82824c. ± Comparison against base commit 0a36c34.

This pull request removes 474 and adds 47 tests. Note that renamed tests count towards both.

com.google.firebase.iid.FirebaseInstanceIdWithFcmReceiverRoboTest ‑ testBindsService_oAndTargetingO
com.google.firebase.iid.FirebaseInstanceIdWithFcmReceiverRoboTest ‑ testNoWrappedIntent
com.google.firebase.iid.FirebaseInstanceIdWithFcmReceiverRoboTest ‑ testNullIntent
com.google.firebase.iid.FirebaseInstanceIdWithFcmReceiverRoboTest ‑ testStartsService_OTargetingO_highPriority
com.google.firebase.iid.FirebaseInstanceIdWithFcmReceiverRoboTest ‑ testStartsService_fallsBackToBindService
com.google.firebase.iid.FirebaseInstanceIdWithFcmReceiverRoboTest ‑ testStartsService_notOButTargetingO
com.google.firebase.iid.FirebaseInstanceIdWithFcmReceiverRoboTest ‑ testStartsService_notOButTargetingO[19]
com.google.firebase.iid.FirebaseInstanceIdWithFcmReceiverRoboTest ‑ testStartsService_notOButTargetingO[21]
com.google.firebase.iid.FirebaseInstanceIdWithFcmReceiverRoboTest ‑ testStartsService_notOButTargetingO[22]
com.google.firebase.iid.FirebaseInstanceIdWithFcmReceiverRoboTest ‑ testStartsService_notOButTargetingO[23]
…

com.google.firebase.inappmessaging.display.FirebaseInAppMessagingDisplayTest ‑ dismissClickListener_dismissesFiam
com.google.firebase.inappmessaging.display.FirebaseInAppMessagingDisplayTest ‑ dismissTimer_onComplete_dismissesFiam
com.google.firebase.inappmessaging.display.FirebaseInAppMessagingDisplayTest ‑ fiamClickListener_whenActionUrlProvided_andBrowserAvailable_opensBrowserIntent
com.google.firebase.inappmessaging.display.FirebaseInAppMessagingDisplayTest ‑ fiamClickListener_whenActionUrlProvided_andChromeAvailable_opensCustomTab
com.google.firebase.inappmessaging.display.FirebaseInAppMessagingDisplayTest ‑ fiamUIListener_whenFiamClicked_receivesOnFiamClick
com.google.firebase.inappmessaging.display.FirebaseInAppMessagingDisplayTest ‑ firebaseInAppMessagingUIListener_whenFiamRendered_receivesOnFiamTrigger
com.google.firebase.inappmessaging.display.FirebaseInAppMessagingDisplayTest ‑ impressionTimer_onComplete_firesImpressionLogAction
com.google.firebase.inappmessaging.display.FirebaseInAppMessagingDisplayTest ‑ inflate_setsActionListenerToDismissFiamOnClick
com.google.firebase.inappmessaging.display.FirebaseInAppMessagingDisplayTest ‑ onActivitPaused_clearsListeners
com.google.firebase.inappmessaging.display.FirebaseInAppMessagingDisplayTest ‑ onActivityNewActivityStarted_displaysFiamInNewActivity
…

♻️ This comment has been updated with latest results.

google-oss-bot · 2023-02-16T23:11:51Z

Size Report ¹

Affected Products

firebase-inappmessaging-display
Type Base (0c1240e) Merge (96bcc51) Diff
aar 180 kB 180 kB +32 B (+0.0%)
apk (aggressive) 1.53 MB 1.53 MB -8 B (-0.0%)
apk (release) 5.21 MB 5.21 MB -64 B (-0.0%)

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/TA3mszH1bm.html

google-oss-bot · 2023-02-16T23:33:49Z

Startup Time Report ¹

Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS.

Notes

This report is for comparing the base commit (0c1240e) and the CI merge commit (96bcc51)
Please check below reports for each individual commit to find more details (Perfetto traces, histograms, detailed measurements)
- 0c1240e: https://storage.googleapis.com/firebase-sdk-metric-reports/9SrdYFOE2h/index.html
- 96bcc51: https://storage.googleapis.com/firebase-sdk-metric-reports/CxekHbKYFG/index.html

Startup Times

`fire-fiam`

Device Statistics Distributions

oriole-32

Percentile	`0c1240e`	`96bcc51`	Diff	Significant (?)
p10	7.31 ±4 ms	5.62 ±2 ms	-1.68 ms (-23.0%)	NO
p25	8.04 ±4 ms	6.05 ±2 ms	-1.99 ms (-24.8%)	NO
p50	9.01 ±5 ms	6.77 ±2 ms	-2.24 ms (-24.9%)	NO
p75	10.3 ±5 ms	7.79 ±2 ms	-2.53 ms (-24.5%)	NO
p90	12.0 ±6 ms	8.83 ±3 ms	-3.21 ms (-26.7%)	NO

20 test runs in comparison

Commit	Test Runs
`0c1240e`	2023-02-17_18:01:37.298182_cSDl 2023-02-17_18:01:37.302451_nqBd 2023-02-17_18:01:37.302486_ZjPD 2023-02-17_18:01:37.302495_ScXe 2023-02-17_18:01:37.302502_LAah 2023-02-17_18:01:37.302510_ktUl 2023-02-17_18:01:37.302516_ULuJ 2023-02-17_18:01:37.302522_EqKs 2023-02-17_18:01:37.302529_JyrQ 2023-02-17_18:01:37.302536_OPhs
`96bcc51`	2023-02-17_19:37:09.368789_VvpO 2023-02-17_19:37:09.381068_clKw 2023-02-17_19:37:09.381108_okpo 2023-02-17_19:37:09.381118_sGpf 2023-02-17_19:37:09.381126_SARn 2023-02-17_19:37:09.381444_txsn 2023-02-17_19:37:09.381457_Daik 2023-02-17_19:37:09.381465_mqYK 2023-02-17_19:37:09.381478_EtOJ 2023-02-17_19:37:09.381485_eMLF

redfin-30

Percentile	`0c1240e`	`96bcc51`	Diff	Significant (?)
p10	15.1 ±6 ms	15.3 ±7 ms	+280 μs (+1.9%)	NO
p25	16.5 ±7 ms	17.0 ±7 ms	+430 μs (+2.6%)	NO
p50	18.8 ±7 ms	19.0 ±8 ms	+223 μs (+1.2%)	NO
p75	21.7 ±8 ms	21.8 ±8 ms	+107 μs (+0.5%)	NO
p90	25.1 ±8 ms	25.3 ±9 ms	+154 μs (+0.6%)	NO

20 test runs in comparison

Commit	Test Runs
`0c1240e`	2023-02-17_18:01:37.298182_cSDl 2023-02-17_18:01:37.302451_nqBd 2023-02-17_18:01:37.302486_ZjPD 2023-02-17_18:01:37.302495_ScXe 2023-02-17_18:01:37.302502_LAah 2023-02-17_18:01:37.302510_ktUl 2023-02-17_18:01:37.302516_ULuJ 2023-02-17_18:01:37.302522_EqKs 2023-02-17_18:01:37.302529_JyrQ 2023-02-17_18:01:37.302536_OPhs
`96bcc51`	2023-02-17_19:37:09.368789_VvpO 2023-02-17_19:37:09.381068_clKw 2023-02-17_19:37:09.381108_okpo 2023-02-17_19:37:09.381118_sGpf 2023-02-17_19:37:09.381126_SARn 2023-02-17_19:37:09.381444_txsn 2023-02-17_19:37:09.381457_Daik 2023-02-17_19:37:09.381465_mqYK 2023-02-17_19:37:09.381478_EtOJ 2023-02-17_19:37:09.381485_eMLF

`fire-fiamd`

Device Statistics Distributions

oriole-32

Percentile	`0c1240e`	`96bcc51`	Diff	Significant (?)
p10	10.2 ±7 ms	9.45 ±3 ms	-733 μs (-7.2%)	NO
p25	10.9 ±8 ms	10.1 ±3 ms	-790 μs (-7.2%)	NO
p50	12.1 ±8 ms	11.3 ±3 ms	-797 μs (-6.6%)	NO
p75	13.8 ±9 ms	12.5 ±3 ms	-1.21 ms (-8.8%)	NO
p90	15.5 ±10 ms	14.5 ±4 ms	-1.06 ms (-6.8%)	NO

20 test runs in comparison

Commit	Test Runs
`0c1240e`	2023-02-17_18:01:37.298182_cSDl 2023-02-17_18:01:37.302451_nqBd 2023-02-17_18:01:37.302486_ZjPD 2023-02-17_18:01:37.302495_ScXe 2023-02-17_18:01:37.302502_LAah 2023-02-17_18:01:37.302510_ktUl 2023-02-17_18:01:37.302516_ULuJ 2023-02-17_18:01:37.302522_EqKs 2023-02-17_18:01:37.302529_JyrQ 2023-02-17_18:01:37.302536_OPhs
`96bcc51`	2023-02-17_19:37:09.368789_VvpO 2023-02-17_19:37:09.381068_clKw 2023-02-17_19:37:09.381108_okpo 2023-02-17_19:37:09.381118_sGpf 2023-02-17_19:37:09.381126_SARn 2023-02-17_19:37:09.381444_txsn 2023-02-17_19:37:09.381457_Daik 2023-02-17_19:37:09.381465_mqYK 2023-02-17_19:37:09.381478_EtOJ 2023-02-17_19:37:09.381485_eMLF

redfin-30

Percentile	`0c1240e`	`96bcc51`	Diff	Significant (?)
p10	17.4 ±11 ms	15.0 ±9 ms	-2.45 ms (-14.1%)	NO
p25	18.7 ±12 ms	16.0 ±9.9 ms	-2.65 ms (-14.2%)	NO
p50	20.3 ±13 ms	17.7 ±11 ms	-2.59 ms (-12.8%)	NO
p75	22.2 ±14 ms	19.3 ±12 ms	-2.93 ms (-13.2%)	NO
p90	25.0 ±15 ms	21.9 ±14 ms	-3.14 ms (-12.6%)	NO

20 test runs in comparison

Commit	Test Runs
`0c1240e`	2023-02-17_18:01:37.298182_cSDl 2023-02-17_18:01:37.302451_nqBd 2023-02-17_18:01:37.302486_ZjPD 2023-02-17_18:01:37.302495_ScXe 2023-02-17_18:01:37.302502_LAah 2023-02-17_18:01:37.302510_ktUl 2023-02-17_18:01:37.302516_ULuJ 2023-02-17_18:01:37.302522_EqKs 2023-02-17_18:01:37.302529_JyrQ 2023-02-17_18:01:37.302536_OPhs
`96bcc51`	2023-02-17_19:37:09.368789_VvpO 2023-02-17_19:37:09.381068_clKw 2023-02-17_19:37:09.381108_okpo 2023-02-17_19:37:09.381118_sGpf 2023-02-17_19:37:09.381126_SARn 2023-02-17_19:37:09.381444_txsn 2023-02-17_19:37:09.381457_Daik 2023-02-17_19:37:09.381465_mqYK 2023-02-17_19:37:09.381478_EtOJ 2023-02-17_19:37:09.381485_eMLF

`timeToInitialDisplay`

Device Statistics Distributions

oriole-32

Percentile	`0c1240e`	`96bcc51`	Diff	Significant (?)
p10	205 ±31 ms	195 ±4 ms	-10.2 ms (-5.0%)	NO
p25	216 ±38 ms	200 ±5 ms	-16.2 ms (-7.5%)	NO
p50	229 ±46 ms	208 ±5 ms	-21.7 ms (-9.5%)	NO
p75	243 ±54 ms	216 ±5 ms	-27.0 ms (-11.1%)	NO
p90	254 ±57 ms	228 ±5 ms	-26.0 ms (-10.2%)	NO

20 test runs in comparison

Commit	Test Runs
`0c1240e`	2023-02-17_18:01:37.298182_cSDl 2023-02-17_18:01:37.302451_nqBd 2023-02-17_18:01:37.302486_ZjPD 2023-02-17_18:01:37.302495_ScXe 2023-02-17_18:01:37.302502_LAah 2023-02-17_18:01:37.302510_ktUl 2023-02-17_18:01:37.302516_ULuJ 2023-02-17_18:01:37.302522_EqKs 2023-02-17_18:01:37.302529_JyrQ 2023-02-17_18:01:37.302536_OPhs
`96bcc51`	2023-02-17_19:37:09.368789_VvpO 2023-02-17_19:37:09.381068_clKw 2023-02-17_19:37:09.381108_okpo 2023-02-17_19:37:09.381118_sGpf 2023-02-17_19:37:09.381126_SARn 2023-02-17_19:37:09.381444_txsn 2023-02-17_19:37:09.381457_Daik 2023-02-17_19:37:09.381465_mqYK 2023-02-17_19:37:09.381478_EtOJ 2023-02-17_19:37:09.381485_eMLF

redfin-30

Percentile	`0c1240e`	`96bcc51`	Diff	Significant (?)
p10	233 ±12 ms	250 ±2 ms	+16.8 ms (+7.2%)	NO
p25	239 ±13 ms	256 ±2 ms	+17.3 ms (+7.2%)	NO
p50	247 ±16 ms	263 ±2 ms	+16.5 ms (+6.7%)	NO
p75	258 ±27 ms	272 ±3 ms	+13.7 ms (+5.3%)	NO
p90	269 ±30 ms	284 ±4 ms	+15.3 ms (+5.7%)	NO

20 test runs in comparison

Commit	Test Runs
`0c1240e`	2023-02-17_18:01:37.298182_cSDl 2023-02-17_18:01:37.302451_nqBd 2023-02-17_18:01:37.302486_ZjPD 2023-02-17_18:01:37.302495_ScXe 2023-02-17_18:01:37.302502_LAah 2023-02-17_18:01:37.302510_ktUl 2023-02-17_18:01:37.302516_ULuJ 2023-02-17_18:01:37.302522_EqKs 2023-02-17_18:01:37.302529_JyrQ 2023-02-17_18:01:37.302536_OPhs
`96bcc51`	2023-02-17_19:37:09.368789_VvpO 2023-02-17_19:37:09.381068_clKw 2023-02-17_19:37:09.381108_okpo 2023-02-17_19:37:09.381118_sGpf 2023-02-17_19:37:09.381126_SARn 2023-02-17_19:37:09.381444_txsn 2023-02-17_19:37:09.381457_Daik 2023-02-17_19:37:09.381465_mqYK 2023-02-17_19:37:09.381478_EtOJ 2023-02-17_19:37:09.381485_eMLF

https://storage.googleapis.com/firebase-sdk-metric-reports/Rm46gUARE2/index.html

.../src/main/java/com/google/firebase/inappmessaging/display/FirebaseInAppMessagingDisplay.java

…ase/inappmessaging/display/FirebaseInAppMessagingDisplay.java Co-authored-by: Rodrigo Lazo <[email protected]>

eldhosembabu added 2 commits February 16, 2023 14:53

Adding null check

398596c

Formatting

f19e9d1

google-oss-bot added the size/XS label Feb 16, 2023

eldhosembabu requested a review from rlazo February 16, 2023 22:56

eldhosembabu added the main-merge-ack label Feb 16, 2023

rlazo reviewed Feb 17, 2023

View reviewed changes

.../src/main/java/com/google/firebase/inappmessaging/display/FirebaseInAppMessagingDisplay.java Outdated Show resolved Hide resolved

.../src/main/java/com/google/firebase/inappmessaging/display/FirebaseInAppMessagingDisplay.java Show resolved Hide resolved

Update firebase-inappmessaging-display/src/main/java/com/google/fireb…

c82824c

…ase/inappmessaging/display/FirebaseInAppMessagingDisplay.java Co-authored-by: Rodrigo Lazo <[email protected]>

eldhosembabu requested a review from rlazo February 17, 2023 19:13

rlazo approved these changes Feb 18, 2023

View reviewed changes

eldhosembabu merged commit c60f76b into master Feb 21, 2023

eldhosembabu deleted the fiam-crash-fix branch February 21, 2023 18:48

eldhosembabu mentioned this pull request Feb 21, 2023

Updating changelog for FIAM #4704

Merged

firebase locked and limited conversation to collaborators Mar 24, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fiam crash fix #4691

Fiam crash fix #4691

eldhosembabu commented Feb 16, 2023

github-actions bot commented Feb 16, 2023 •

edited

Loading

google-oss-bot commented Feb 16, 2023

google-oss-bot commented Feb 16, 2023 •

edited

Loading

github-actions bot commented Feb 16, 2023 •

edited

Loading

google-oss-bot commented Feb 16, 2023 •

edited

Loading

`firebase-inappmessaging-display`

google-oss-bot commented Feb 16, 2023 •

edited

Loading

`fire-fiam`

`fire-fiamd`

`timeToInitialDisplay`

Fiam crash fix #4691

Fiam crash fix #4691

Conversation

eldhosembabu commented Feb 16, 2023

github-actions bot commented Feb 16, 2023 • edited Loading

📝 PRs merging into main branch

google-oss-bot commented Feb 16, 2023

google-oss-bot commented Feb 16, 2023 • edited Loading

Coverage Report 1

Affected Products

Test Logs

github-actions bot commented Feb 16, 2023 • edited Loading

Unit Test Results

google-oss-bot commented Feb 16, 2023 • edited Loading

Size Report 1

Affected Products

firebase-inappmessaging-display

Test Logs

google-oss-bot commented Feb 16, 2023 • edited Loading

Startup Time Report 1

Notes

Startup Times

fire-fiam

fire-fiamd

timeToInitialDisplay

github-actions bot commented Feb 16, 2023 •

edited

Loading

google-oss-bot commented Feb 16, 2023 •

edited

Loading

Coverage Report ¹

github-actions bot commented Feb 16, 2023 •

edited

Loading

google-oss-bot commented Feb 16, 2023 •

edited

Loading

Size Report ¹

`firebase-inappmessaging-display`

google-oss-bot commented Feb 16, 2023 •

edited

Loading

Startup Time Report ¹

`fire-fiam`

`fire-fiamd`

`timeToInitialDisplay`