Skip to content

Fix Fiam crash at AbtIntegrationHelper #4913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 19, 2023
Merged

Fix Fiam crash at AbtIntegrationHelper #4913

merged 3 commits into from
Apr 19, 2023

Conversation

eldhosembabu
Copy link
Contributor

@eldhosembabu eldhosembabu commented Apr 18, 2023 •
edited
Loading

Fix NullPointerException at AbtIntegrationHelper.setExperimentActive

Issue was because of executor being null in AbtIntegrationHelper. Internal bug: reference b/278729431

Github issue: #4716

@github-actions
Copy link
Contributor

github-actions bot commented Apr 18, 2023 •
edited
Loading

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

@eldhosembabu eldhosembabu requested a review from rlazo April 18, 2023 20:58
@github-actions
Copy link
Contributor

github-actions bot commented Apr 18, 2023 •
edited
Loading

Unit Test Results

  56 files   -    102    56 suites   - 102   2m 37s ⏱️ +23s
316 tests  -    808  315 ✔️  -    793  1 💤  - 15  0 ❌ ±0 
632 runs   - 1 616  630 ✔️  - 1 586  2 💤  - 30  0 ❌ ±0 

Results for commit ee7d551. ± Comparison against base commit 9a9a02b.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 18, 2023 •
edited
Loading

Coverage Report 1

Affected Products

  • firebase-inappmessaging-display

    Overall coverage changed from ? (9a9a02b) to 0.00% (ca285b8) by ?.

    73 individual files with coverage change

    FilenameBase (9a9a02b)Merge (ca285b8)Diff
    AppComponent.java?0.00%?
    ApplicationModule.java?0.00%?
    ApplicationModule_ProvidesApplicationFactory.java?0.00%?
    BackButtonHandler.java?0.00%?
    BackButtonLayout.java?0.00%?
    BannerBindingWrapper.java?0.00%?
    BannerBindingWrapper_Factory.java?0.00%?
    BaseModalLayout.java?0.00%?
    BindingWrapper.java?0.00%?
    BindingWrapperFactory.java?0.00%?
    BindingWrapperFactory_Factory.java?0.00%?
    CardBindingWrapper.java?0.00%?
    CardBindingWrapper_Factory.java?0.00%?
    CardLayoutLandscape.java?0.00%?
    CardLayoutPortrait.java?0.00%?
    DaggerAppComponent.java?0.00%?
    DaggerInAppMessageComponent.java?0.00%?
    DaggerUniversalComponent.java?0.00%?
    FiamAnimator.java?0.00%?
    FiamAnimator_Factory.java?0.00%?
    FiamCardView.java?0.00%?
    FiamFrameLayout.java?0.00%?
    FiamImageLoader.java?0.00%?
    FiamImageLoader_Factory.java?0.00%?
    FiamListener.java?0.00%?
    FiamRelativeLayout.java?0.00%?
    FiamWindowManager.java?0.00%?
    FiamWindowManager_Factory.java?0.00%?
    FirebaseAppScope.java?0.00%?
    FirebaseInAppMessagingDisplay.java?0.00%?
    FirebaseInAppMessagingDisplayImpl.java?0.00%?
    FirebaseInAppMessagingDisplayRegistrar.java?0.00%?
    FirebaseInAppMessagingDisplay_Factory.java?0.00%?
    GlideErrorListener.java?0.00%?
    GlideErrorListener_Factory.java?0.00%?
    GlideModule.java?0.00%?
    GlideModule_ProvidesGlideRequestManagerFactory.java?0.00%?
    HeadlessInAppMessagingModule.java?0.00%?
    HeadlessInAppMessagingModule_ProvidesHeadlesssSingletonFactory.java?0.00%?
    ImageBindingWrapper.java?0.00%?
    ImageBindingWrapper_Factory.java?0.00%?
    InAppMessageComponent.java?0.00%?
    InAppMessageLayoutConfig.java?0.00%?
    InAppMessageScope.java?0.00%?
    InflaterConfigModule.java?0.00%?
    InflaterConfigModule_ProvidesBannerLandscapeLayoutConfigFactory.java?0.00%?
    InflaterConfigModule_ProvidesBannerPortraitLayoutConfigFactory.java?0.00%?
    InflaterConfigModule_ProvidesCardLandscapeConfigFactory.java?0.00%?
    InflaterConfigModule_ProvidesCardPortraitConfigFactory.java?0.00%?
    InflaterConfigModule_ProvidesDisplayMetricsFactory.java?0.00%?
    InflaterConfigModule_ProvidesLandscapeImageLayoutConfigFactory.java?0.00%?
    InflaterConfigModule_ProvidesModalLandscapeConfigFactory.java?0.00%?
    InflaterConfigModule_ProvidesModalPortraitConfigFactory.java?0.00%?
    InflaterConfigModule_ProvidesPortraitImageLayoutConfigFactory.java?0.00%?
    InflaterModule.java?0.00%?
    InflaterModule_InAppMessageLayoutConfigFactory.java?0.00%?
    InflaterModule_ProvidesBannerMessageFactory.java?0.00%?
    InflaterModule_ProvidesInflaterserviceFactory.java?0.00%?
    LayoutConfigKey.java?0.00%?
    Logging.java?0.00%?
    MeasureUtils.java?0.00%?
    ModalBindingWrapper.java?0.00%?
    ModalBindingWrapper_Factory.java?0.00%?
    ModalLayoutLandscape.java?0.00%?
    ModalLayoutPortrait.java?0.00%?
    OnSwipeUpListener.java?0.00%?
    RenewableTimer.java?0.00%?
    RenewableTimer_Factory.java?0.00%?
    ResizableImageView.java?0.00%?
    SwipeDismissTouchListener.java?0.00%?
    UniversalComponent.java?0.00%?
    VerticalViewGroupMeasure.java?0.00%?
    ViewMeasure.java?0.00%?

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/uqSzoQWgrb.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 18, 2023 •
edited
Loading

Size Report 1

Affected Products

  • firebase-inappmessaging

    TypeBase (9a9a02b)Merge (ca285b8)Diff
    aar454 kB452 kB-1.56 kB (-0.3%)
    apk (aggressive)698 kB700 kB+1.31 kB (+0.2%)
    apk (release)3.95 MB3.95 MB+136 B (+0.0%)

  • firebase-inappmessaging-display

    TypeBase (9a9a02b)Merge (ca285b8)Diff
    apk (aggressive)1.53 MB1.53 MB+1.72 kB (+0.1%)
    apk (release)5.21 MB5.21 MB-656 B (-0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/oy6z3CLj9T.html

@argzdev argzdev mentioned this pull request Apr 19, 2023
Closed
@google-oss-bot
Copy link
Contributor

Startup Time Report 1

Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS.

Startup time comparison between the CI merge commit (ca285b8) and the base commit (9a9a02b) are not available.

No macrobenchmark data found for the base commit (9a9a02b). Analysis for the CI merge commit (ca285b8) can be found at:

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/6PM2b7KnUf/index.html

@eldhosembabu eldhosembabu merged commit cab309e into master Apr 19, 2023
@eldhosembabu eldhosembabu deleted the fiam-crash-4716 branch April 19, 2023 16:48
@firebase firebase locked and limited conversation to collaborators Jun 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rlazo rlazo rlazo approved these changes

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eldhosembabu @google-oss-bot @rlazo