Making methods in core.Query that memoize results thread safe. #5099
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release note changesThe following release notes were modified. Please ensure they look correct. Release Notesfirebase-firestore### {{firestore}} version 24.6.2 {: #firestore_v24-6-2}
* {{feature}} Expose MultiDb support in API. GitHub [#4015](//github.com/firebase/firebase-android-sdk/issues/4015){: .external}
* {{fixed}} Fixed a thread interference issue that may lead to a ConcurrentModificationException.
(GitHub [#5091](//github.com/firebase/firebase-android-sdk/issues/5091){: .external})
#### {{firestore}} Kotlin extensions version 24.6.2 {: #firestore-ktx_v24-6-2}
The Kotlin extensions library transitively includes the updated
`firebase-firestore` library. The Kotlin extensions library has no additional
updates. |
Unit Test Results 162 files - 632 162 suites - 632 2m 27s ⏱️ - 32m 43s Results for commit 5d0503a. ± Comparison against base commit d028b21. ♻️ This comment has been updated with latest results. |
Coverage Report 1Affected Products
Test Logs |
Size Report 1Affected Products
Test Logs |
Startup Time Report 1Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS. Notes
Startup Times
|
wu-hui
reviewed
Jun 23, 2023
firebase-firestore/src/main/java/com/google/firebase/firestore/core/Query.java
Outdated
Show resolved
Hide resolved
firebase-firestore/src/main/java/com/google/firebase/firestore/core/Query.java
Outdated
Show resolved
Hide resolved
firebase-firestore/src/main/java/com/google/firebase/firestore/core/Query.java
Outdated
Show resolved
Hide resolved
firebase-firestore/src/test/java/com/google/firebase/firestore/core/QueryTest.java
Show resolved
Hide resolved
wu-hui
approved these changes
Jun 26, 2023
Georgezhang714
suggested changes
Jun 26, 2023
firebase-firestore/src/main/java/com/google/firebase/firestore/core/Query.java
Show resolved
Hide resolved
firebase-firestore/src/test/java/com/google/firebase/firestore/core/QueryTest.java
Show resolved
Hide resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.