Skip to content

Add CHANGELOG for latency-compensated query fix #622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
3 commits merged into from
Jul 16, 2019
Merged

Conversation

ghost
Copy link

@ghost ghost commented Jul 16, 2019

Add changelog for #621.

#621 also fixed #155

@ghost ghost added the api: firestore label Jul 16, 2019
@googlebot googlebot added the cla: yes Override cla label Jul 16, 2019
@ghost ghost requested a review from wilhuff July 16, 2019 15:54
Copy link
Contributor

@wilhuff wilhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -1,4 +1,6 @@
# Unreleased
- [fixed] Fixed an issue where query results were temporarily missing documents
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is actually going to go out with 20.2.0 if we submit today, so please move down one section.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, please add a reference to the issue (#155) before the trailing period.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@wilhuff wilhuff assigned ghost Jul 16, 2019
@ghost ghost merged commit b36d6c0 into master Jul 16, 2019
@rlazo rlazo deleted the wuandy/UpdateChangeLog branch September 27, 2019 14:55
@firebase firebase locked and limited conversation to collaborators Oct 9, 2019
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Firestore] whereArrayContains not working in offline scenario.
4 participants