Update README to suggest Python3 versions #702
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As Python 2 is out of support, this updates the readme to suggest supported versions 3.6+
jonsimantov
reviewed
Oct 8, 2021
README.md
Outdated
| @@ -52,7 +52,7 @@ The following prerequisites are required for all platforms. Be sure to add any | |||
| directories to your PATH as needed. | |||
|
|
|||
| - [CMake](https://cmake.org/), version 3.1, or newer | |||
| - [Python2](https://www.python.com/), version of 2.7, or newer | |||
| - [Python](https://www.python.com/), version of 3.6, or newer | |||
There was a problem hiding this comment.
Have you tested on Python 3.6? As you noted, CI uses Python 3.7, so it might be better to require that.
There was a problem hiding this comment.
I was building using my default (3.10), but moving to 3.7, matching CI, makes sense.
Also, 3.6 is out of support EoY (soon)
a-maurice
approved these changes
Oct 15, 2021
|
Sorry, due to an issue with our CI we'll have to merge this for you, @crwilcox. OK to merge? |
|
Yep! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As Python 2 is out of support, this updates the readme to suggest supported versions 3.6+. Python 2.7 should still work. I verified this works for firebase_analytics, perhaps 2.7 is needed for something else?
CI seems to be using Python 3.7 today.
firebase-cpp-sdk/.github/workflows/cpp-packaging.yml
Line 197 in 196188e