Incorrect comment in code.

[mortenbekditlevsen]

The comment on the referred line specifies that the order of supportedAuthDomains matters. But the outer loop is the authorized domains from the web request, so actually the first match in the authorized domains list 'wins'.
The inner and outer loops should be switched for the comment to be correct.

firebase-ios-sdk/FirebaseAuth/Sources/Utilities/FIRAuthWebUtils.m

Line 107 in 31307cd

// The sequence of supportedAuthDomains matters. ("firebaseapp.com", "web.app")

[google-oss-bot]

I found a few problems with this issue:

• I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.
• This issue does not seem to follow the issue template. Make sure you provide all the required information.

[mortenbekditlevsen]

Just to make my initial comment a bit clearer:

Currently, the supportedAuthDomains order does not matter (as opposed to what's stated in the comment) - the returned domain will be determined by the order of response.authorizedDomains.

If response.authorizedDomains contains ["my.web.app", "my.firebaseapp.com"], then we would first look to see if my.web.app matched any of ["firebaseapp.com", "web.app"], which it does and then "my.web.app" will be used.

If the response order was different: ["my.firebaseapp.com", "my.web.app"], then the first match would be for my.firebaseapp.com.

And thus, contrary to the comment, it's not the order of supportedAuthDomains that matters, but the order of response.authorizedDomains that matters. And the latter is not controlled by the library, so that seems like an error - if indeed the order of supportedAuthDomains matters.

[paulb777]

@rosalyntan Should the comment be fixed or the code updated to match the comment?

cc: @renkelvin

[renkelvin]

I think we should update the code to match the comment.

[paulb777]

The code is updated in the release-11.0 branch: https://github.com/firebase/firebase-ios-sdk/blob/release-11.0/FirebaseAuth/Sources/Swift/Utilities/AuthWebUtils.swift#L117

[mortenbekditlevsen]

Well, on line 130 and 131 the iteration of supportedAuthDomains is still nested in the iteration of the response domains, so the order or supportedAuthDomains still doesn't matter, does it?

[paulb777]

Oops. Good catch, Morten! I'll reopen the issue and send a PR.