Skip to content

Fix the handling of Unicode characters in log and assertion messages#8372

Merged
var-const merged 2 commits intomasterfrom
varconst/fix-unicode-logging2
Jul 10, 2021
Merged

Fix the handling of Unicode characters in log and assertion messages#8372
var-const merged 2 commits intomasterfrom
varconst/fix-unicode-logging2

Conversation

@var-const
Copy link
Copy Markdown
Contributor

Currently, any UTF-8 characters outside the ascii set may be encoded incorrectly.

@google-cla google-cla Bot added the cla: yes label Jul 9, 2021
Comment thread Firestore/core/src/util/exception_apple.mm
@google-oss-bot
Copy link
Copy Markdown
Collaborator

google-oss-bot commented Jul 10, 2021

Coverage Report

Affected SDKs

  • FirebaseFirestore-iOS-FirebaseFirestore.framework

    SDK overall coverage changed from 88.49% (d50dd0a) to 88.53% (e06d665) by +0.04%.

    Filename Base (d50dd0a) Head (e06d665) Diff
    leveldb_key.cc 96.79% 97.96% +1.17%
    ordered_code.cc 92.68% 93.24% +0.56%
    task.cc 95.21% 96.41% +1.20%
    write_stream.cc 95.65% 93.48% -2.17%

Test Logs

Comment thread Firestore/core/src/util/exception_apple.mm
@dconeybe dconeybe assigned var-const and unassigned dconeybe Jul 10, 2021
@var-const var-const merged commit bd64ba6 into master Jul 10, 2021
@var-const var-const deleted the varconst/fix-unicode-logging2 branch July 10, 2021 01:25
@firebase firebase locked and limited conversation to collaborators Aug 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants