-
Notifications
You must be signed in to change notification settings - Fork 1.6k
[FirebaseCoreInternal] Guard against invalid indexing into RingBuffer
type
#10032
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morganchen12
approved these changes
Jul 20, 2022
Coverage Report 1Affected Products
Test Logs |
paulb777
reviewed
Jul 20, 2022
paulb777
reviewed
Jul 21, 2022
FirebaseCore/Internal/Sources/HeartbeatLogging/RingBuffer.swift
Outdated
Show resolved
Hide resolved
RingBuffer
codeRingBuffer
type
paulb777
reviewed
Jul 21, 2022
FirebaseCore/Internal/Sources/HeartbeatLogging/RingBuffer.swift
Outdated
Show resolved
Hide resolved
paulb777
approved these changes
Jul 21, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
An issue was reported where the issue's crash report suggests an index out of bounds exception in the
RingBuffer
type. This type is used by FirebaseCoreInternal's heartbeat component.RingBuffer
internally manages an insertion index that is incremented/decremented to always be within the inner array's bounds. In the reported issue, that assumption was being broken for some reason.To prevent the crash, the crashing
RingBuffer
API is converted to a throwing method that throws an error if the insertion index is out of bounds. This is gracefully handled in the calling context to reset the ring buffer in an effort to return things to a normal state.Fixes #10025