Auth Emulator support #6402
Merged
Auth Emulator support #6402
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
…eatures when using the emulator.
|
Test failure looks to be a transient failure, from hitting Facebook's API request limit. |
yuchenshi
requested changes
Sep 9, 2020
There was a problem hiding this comment.
The terms used are really confusing here, so let's clear them up a bit.
http://localhost:9000/foo/bar/baz<-- URL or URI, whichever is consistent with existing codelocalhost<--- Host (a.k.a. "hostname")9000<--- Portlocalhost:9000<--- hostAndPort (a.k.a. as just "host" in RFC for URLs, but that's not consistent with the iOS SDK terms)
Please rename variables accordingly. e.g. requestConfiguration.emulatorURL should be renamed to emulatorHostAndPort, or just keep two separate variables. This will make templating much much easier to reason about.
yuchenshi
reviewed
Sep 9, 2020
yuchenshi
approved these changes
Sep 10, 2020
yuchenshi
reviewed
Sep 10, 2020
renkelvin
approved these changes
Sep 10, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement support for the auth emulator. The entry point is in an internal header for now, and will be moved to the public header when ready for release.