CMake grpc upgrade to 1.44.0 #9488
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4c86c03 to
129cafa
Compare
Size Report 1Affected ProductsTest Logs |
Coverage Report 1Affected Products
Test Logs |
129cafa to
72779cb
Compare
paulb777
approved these changes
May 2, 2022
ehsannas
approved these changes
May 2, 2022
dconeybe
added a commit
to firebase/firebase-cpp-sdk
that referenced
this pull request
May 31, 2022
This fixes the following build error:
```
The following tests FAILED:
1 - charclass_test (Not Run)
2 - compile_test (Not Run)
3 - filtered_re2_test (Not Run)
4 - mimics_pcre_test (Not Run)
...
```
e.g. https://github.com/firebase/firebase-cpp-sdk/runs/6676610733
This is caused by the addition of re2 to the firebase-ios-sdk in firebase/firebase-ios-sdk#9488.
I'm not sure _why_ these tests can't be found; but they're superfluous anyways. So just disable them.
cynthiajoan
pushed a commit
to firebase/firebase-cpp-sdk
that referenced
this pull request
Jun 1, 2022
* Update iOS dependencies - Tue May 31 2022 ### iOS - Firebase/Analytics → 9.1.0 - Firebase/Auth → 9.1.0 - Firebase/Core → 9.1.0 - Firebase/Crashlytics → 9.1.0 - Firebase/Database → 9.1.0 - Firebase/DynamicLinks → 9.1.0 - Firebase/Firestore → 9.1.0 - Firebase/Functions → 9.1.0 - Firebase/Installations → 9.1.0 - Firebase/Messaging → 9.1.0 - Firebase/RemoteConfig → 9.1.0 - Firebase/Storage → 9.1.0 > Created by [Update Android and iOS dependencies workflow](https://github.com/firebase/firebase-cpp-sdk/actions/runs/2416912624). * CMakeLists.txt: set(RE2_BUILD_TESTING OFF CACHE BOOL "") This fixes the following build error: ``` The following tests FAILED: 1 - charclass_test (Not Run) 2 - compile_test (Not Run) 3 - filtered_re2_test (Not Run) 4 - mimics_pcre_test (Not Run) ... ``` e.g. https://github.com/firebase/firebase-cpp-sdk/runs/6676610733 This is caused by the addition of re2 to the firebase-ios-sdk in firebase/firebase-ios-sdk#9488. I'm not sure _why_ these tests can't be found; but they're superfluous anyways. So just disable them. * value_util.cc: Fix MaxValue() to no longer use designated initialization. This ports firebase/firebase-ios-sdk#9868 to the firebase-cpp-sdk repository by patching the firebase-ios-sdk when it is cloned. Once the dependency on the firebase-ios-sdk is updated to a version that already includes firebase/firebase-ios-sdk#9868 then this commit should be reverted. Co-authored-by: firebase-workflow-trigger-bot <[email protected]> Co-authored-by: Denver Coneybeare <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The long-overdue upgrade of grpc to 1.44.0.
The newer version caused link issues on Mac for ASAN build, I have temporarily disabled that, and added ASAN build on Unbuntu, which seems to do more checks than on Mac. It has discovered a memory leak issue from a recent PR. Will fix the leak in a following PR.