firebase-ios-sdk/1499: Restart streams on any token change. #1120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See firebase/firebase-ios-sdk#1499 This reworks our UserListener into a CredentialChangeListener which fires on any token change, even if the User did not change. This allows us to restart our streams (but not switch mutation queues, etc.) on token changes.
wilhuff
approved these changes
Aug 14, 2018
| * This isn't actually necessary since the UID never changes, but we use this | ||
| * to verify the listen contract is adhered to in tests. | ||
| */ | ||
| private userListener: UserListener | null = null; | ||
| private listener: CredentialChangeListener | null = null; |
There was a problem hiding this comment.
We call this a changeListener below. Could we make these consistent?
mikelehen
pushed a commit
to firebase/firebase-ios-sdk
that referenced
this pull request
Aug 14, 2018
[Port of firebase/firebase-js-sdk#1120] Fixes #1499. This reworks our "user listener" into a "credential change listener" that fires on any token change, even if the User did not change. This allows us to restart our streams (but not switch mutation queues, etc.) on token changes.
mikelehen
added a commit
to firebase/firebase-ios-sdk
that referenced
this pull request
Aug 15, 2018
[Port of firebase/firebase-js-sdk#1120] Fixes #1499. This reworks our "user listener" into a "credential change listener" that fires on any token change, even if the User did not change. This allows us to restart our streams (but not switch mutation queues, etc.) on token changes.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See firebase/firebase-ios-sdk#1499
This reworks our UserListener into a CredentialChangeListener which
fires on any token change, even if the User did not change. This allows
us to restart our streams (but not switch mutation queues, etc.) on token
changes.