v2 functions stopped working upon upgrade to v12.5.0

[mazenkhalil]

[REQUIRED] Environment info

firebase-tools: v12.5.0

Platform: macOS

Using the latest firebase-tools version (12.5.0) causes runtime error in v2 functions.

Downgrading to v12.4.8 solves the issue, but had to delete the whole function beforehand.

stacktrace

[google-oss-bot]

This issue does not seem to follow the issue template. Make sure you provide all the required information.

[atsjo]

same for me, also noticed that combining v1 and v2 functions will fail v1 functions during deploy... but didn't need to remove functions to fix this, just changed the my functions a bit (to not skip during deploy) and redeployed with 12.4.8 fixed the issue.

This is caused by #6275 which is to avoid building separate images for functions inside same source code, but ends up breaking execution during runtime. There is no error in cloud build or during deploy (except when combining v1 and v2 functions)

Functions deploy had errors with the following functions:
        createUser(europe-west3)
        deleteUser(europe-west3)

Platform: windows

[aalej]

Thanks for reporting this issue @mazenkhalil, and thanks @atsjo for the additional information. So far, I am able to reproduce the error when trying to deploy a combination of v1 and v2 functions. I’ll notify our team about this so that they can take a look. However, I did not encounter an issue when deploying just v2 functions and when invoking a v2 function.

@mazenkhalil, let me know if I may be wrong but from my understanding you are encountering the issue during v2 function runtime. I’d like to ask if you could provide a sample code snippet of the function you’re deploying so that we can reproduce the issue on our end?

[cabello]

We noticed unexpected errors as well. We added log.info at the beginning of each Cloud Function and some of them were crashing before being called:

Error: TypeError: res.on is not a function

We learned by deleting the function and deploying it fresh it would work again, but next deployment would cause the issue.

The other error we saw Request body is missing data.

We only have v2 functions.

We use a single build with functions being in separate files:

// file: index.ts
export { foo } from "./foo"
export { bar } from "./bar"
export { qux } from "./qux"

Our current tsconfig.json:

{
  "compilerOptions": {
    "target": "ES2017",
    "module": "CommonJS",
    "skipLibCheck": true,
    "noImplicitReturns": true,
    "noUnusedLocals": true,
    "outDir": "dist",
    "sourceMap": true,
    "strict": true
  },
  "compileOnSave": true,
  "include": ["src"]
}

I suspected the resulting build code so I tried different targets and module resolutions but that crashed when deploying. The code looked modern but Firebase could not analyze the source code:

Functions codebase could not be analyzed successfully. It may have a syntax or runtime error

Rolling back to 12.4.X fixed the issue, we no longer have functions misbehaving.

[atsjo]

It works with v2 if I only deploy 1 function, but with several they fail runtime. I have a combination of firestore triggers, http and a scheduled function. All with newest deps and a esm bundle with functions running on node 18. I see different errors like the ones above, and my scheduled function end up with this:

Request has incorrect Content-Type.
Error: Invalid request, unable to process.
    at entryFromArgs (/workspace/node_modules/.pnpm/firebase-functions@4.4.1_firebase-admin@11.10.1/node_modules/firebase-functions/lib/logger/index.js:130:19)
    at Object.error (/workspace/node_modules/.pnpm/firebase-functions@4.4.1_firebase-admin@11.10.1/node_modules/firebase-functions/lib/logger/index.js:116:11)
    at /workspace/node_modules/.pnpm/firebase-functions@4.4.1_firebase-admin@11.10.1/node_modules/firebase-functions/lib/common/providers/https.js:405:24
    at /workspace/node_modules/.pnpm/firebase-functions@4.4.1_firebase-admin@11.10.1/node_modules/firebase-functions/lib/common/providers/https.js:394:25
    at cors (/workspace/node_modules/.pnpm/cors@2.8.5/node_modules/cors/lib/index.js:188:7)
    at /workspace/node_modules/.pnpm/cors@2.8.5/node_modules/cors/lib/index.js:224:17
    at originCallback (/workspace/node_modules/.pnpm/cors@2.8.5/node_modules/cors/lib/index.js:214:15)
    at /workspace/node_modules/.pnpm/cors@2.8.5/node_modules/cors/lib/index.js:219:13
    at optionsCallback (/workspace/node_modules/.pnpm/cors@2.8.5/node_modules/cors/lib/index.js:199:9)
    at corsMiddleware (/workspace/node_modules/.pnpm/cors@2.8.5/node_modules/cors/lib/index.js:204:7)"

everything works fine when I switch back to 12.4.8

[iampava]

Lol, I thought I was going crazy. My functions suddenly weren't working. Reverted back to 12.14.8 seems ok

[milo-]

Yep. This just took down our app when our CI environment picked up 12.5

[blidd-google]

Hi all, question — are you able to successfully deploy multiple v2 functions? I've discovered an issue with mixed v1 / v2 deployments, but I'd like to confirm that multiple v2 functions are still deploying.