fix(storage, web): fixed web stream handlers, e2e web tests, incorrect NativeError being thrown instead of FirebaseException on web #12319
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tions and wasn't calling onDone
…g `false` when cancelling task
task.cancel() on apple
task.cancel() on apple task.cancel() on apple
task.cancel() on apple
exaby73
approved these changes
Feb 13, 2024
rrousselGit
reviewed
Feb 14, 2024
| return exception is core_interop.FirebaseError; | ||
| bool _testException(Object? objectException) { | ||
| final exception = objectException! as core_interop.JSError; | ||
| // ignore: unnecessary_cast |
There was a problem hiding this comment.
The analyser was causing a warning if the cast isn't there. Not entirely sure why but might be something to do with the shimmer for all platforms.
rrousselGit
approved these changes
Feb 14, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes to Web
snapshotEventsto ensure it was properly closed and callingonDonemethod.flutter.darttoreference_web.dartas it should be.Related Issues
Replace this paragraph with a list of issues related to this PR from the issue database. Indicate, which of these issues are resolved or fixed by this PR. Note that you'll have to prefix the issue numbers with flutter/flutter#.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process. Updating the
pubspec.yamland changelogs is not required.///).melos run analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?