Skip to content

Add support for template-haskell 2.17 #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 23, 2021
Merged

Add support for template-haskell 2.17 #15

merged 2 commits into from
Jun 23, 2021

Conversation

felixonmars
Copy link
Contributor

This is based on the change in
snoyberg/githash#22

All tests are passing.

@felixonmars
Add support for template-haskell 2.17
09cd01d 
This is based on the change in
snoyberg/githash#22

All tests are passing.
snoyberg
snoyberg requested changes Jun 22, 2021
View reviewed changes
Copy link
Member

@snoyberg snoyberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a minor version bump and changelog entry?

snoyberg
snoyberg approved these changes Jun 23, 2021
View reviewed changes
Copy link
Member

@snoyberg snoyberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@snoyberg snoyberg merged commit a5ecf00 into fpco:master Jun 23, 2021
@felixonmars felixonmars deleted the th-2.17 branch June 23, 2021 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snoyberg snoyberg snoyberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@felixonmars @snoyberg