Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: freckle/yesod-page-cursor
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v2.0.0.0
Choose a base ref
...
head repository: freckle/yesod-page-cursor
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v2.0.0.1
Choose a head ref
  • 4 commits
  • 4 files changed
  • 2 contributors

Commits on Jan 4, 2021

  1. Add newly-required extensions in TestApp 

    Fixes #20.
    @pbrisbin
    pbrisbin committed Jan 4, 2021
    Configuration menu
    Copy the full SHA
    c056d87 View commit details
    Browse the repository at this point in the history

  2. Add some dependency bounds 

    This is a bit nuanced, and I'm not sure if it's the best approach, so
here is some explanation:

Managing dependency bounds manually is an error-prone pain. Stack
supports a --pvp-bounds option to sdist (and upload, which uses it) to
automate the process. It can add lower bounds, upper bounds, or both. It
operates by looking at the version of every dependency in the resolver
in use and sets a >= lower bound on that version and a < upper bound on
the next major version.

See https://www.fpcomplete.com/blog/2015/09/stack-pvp/

We've decided to omit bounds in our committed source generally, and use
the --pvp-bounds both option when releasing to Hackage. This is a
conservative choice, adding tight bounds based on the latest LTS
resolver, which is what we typically prefer in stack.yaml.

Where this breaks down is when building the project, with those
automated pvp-bounds, against nightly. Since the "next major" upper
bound is relative to the current LTS resolver, it's likely that the
nightly resolver will have a newer version and not build. Worse, you
can't know this until you actually try to build from the package built
with sdist -- since bounds aren't committed in package.yaml.

The solution is simple but annoying: add back manual bounds that are
more relaxed, which is what this commit does.

Will this be just as error prone and annoying as not using the
pvp-bounds option at all? Would using pvp-bounds upper or lower only
work out better for us? I'm not sure, we'll see.
    @pbrisbin
    pbrisbin committed Jan 4, 2021
    Configuration menu
    Copy the full SHA
    151595e View commit details
    Browse the repository at this point in the history

  3. Prepare next version

    @pbrisbin
    pbrisbin committed Jan 4, 2021
    Configuration menu
    Copy the full SHA
    69c0a2a View commit details
    Browse the repository at this point in the history

  4. Restyled by prettier-markdown

    @restyled-commits @pbrisbin
    restyled-commits authored and pbrisbin committed Jan 4, 2021
    Configuration menu
    Copy the full SHA
    b20fe8f View commit details
    Browse the repository at this point in the history
Loading