clip : improve projector naming #13118
Merged
+235
−306
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't quite like the abstract naming like "resample", "merger", etc. It can be useful if one projector can be reused by various vision models. But unfortunately, that has hardly been the case.
The cumbersome
bool has_*_projector
pattern is also removed. The only variable being kept ishas_llava_projector
, because bothMLP, MLP_NORM, LDP, LDPV2
are considered variants of llava projector.Test result: