Skip to content

Consistently catch and throw only exceptions deriving from std::exception #1599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 5, 2023
Merged

Consistently catch and throw only exceptions deriving from std::exception #1599

merged 3 commits into from
Jun 5, 2023

Conversation

mgroeber9110
Copy link
Contributor

@mgroeber9110 mgroeber9110 commented May 26, 2023 •
edited
Loading

This change makes sure that all exceptions thrown and caught are derived from std::exception (typically, std::runtime_error), rather than mixing std::string and std::runtime_error in different parts of the code.

This should fix #1569 and fix #1589 and completes the changes in #1316 (which already changed exception types to std::runtime_error in llama-util.h).

@ggerganov ggerganov merged commit c2df36d into ggml-org:master Jun 5, 2023
@Bearsaerker Bearsaerker mentioned this pull request Mar 12, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@divinity76 divinity76 divinity76 approved these changes

@ivanstepanovftw ivanstepanovftw ivanstepanovftw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

std::runtime_error exceptions not caught as std::string by Visual C++? terminate called after throwing an instance of 'std::runtime_error'
4 participants
@mgroeber9110 @divinity76 @ivanstepanovftw @ggerganov