Allow the user to specify the path to the OpenBLAS headers. (#627) #806
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
howard0su
reviewed
Apr 6, 2023
CMakeLists.txt
Outdated
| @@ -60,6 +60,9 @@ option(LLAMA_FMA "llama: enable FMA" | |||
| # 3rd party libs | |||
| option(LLAMA_ACCELERATE "llama: enable Accelerate framework" ON) | |||
| option(LLAMA_OPENBLAS "llama: use OpenBLAS" OFF) | |||
| if (LLAMA_OPENBLAS) | |||
There was a problem hiding this comment.
Why not use FindPackage for OPENBLAS?
There was a problem hiding this comment.
find_package is used below, at line 115. find_package(BLAS) does not return the include path, only the path to the library. The current CMakeLists doesn't add -I/usr/include/openblas and the generated makefile are unable to build llama on Fedora.
/home/vincenzo/Projects/llama.cpp/ggml.c:145:10: fatal error: cblas.h: File o directory non esistente 145 | #include <cblas.h>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, this patch allow the user to specify the path of OpenBLAS headers.
As default the path is set to "/usr/include"
Thank you.
Vincenzo