Rust: expand attribute macros #19334
Conversation
| @@ -5,6 +5,7 @@ | |||
|
|
|||
| private import internal.ItemImpl | |||
| import codeql.rust.elements.Addressable | |||
| import codeql.rust.elements.AstNode | |||
Check warning
Code scanning / CodeQL
Redundant import Warning
7c8fc79 to
49cf173
Compare
getExpended on Items| @@ -0,0 +1,2 @@ | |||
| | attr_macro_expansion.rs:1:1:2:11 | fn foo | attr_macro_expansion.rs:2:4:2:6 | Static | | |||
| | attr_macro_expansion.rs:1:1:2:11 | fn foo | attr_macro_expansion.rs:2:4:2:10 | fn foo | | |||
There was a problem hiding this comment.
Why is it not the attribute that is expanded? It seems weird that the function can expand to two things.
There was a problem hiding this comment.
that's what the attribute macro does: it takes in an AST (in this case, the definition of a function) and replaces it with possibly multiple items like in this case. So it's not really the attribute that is expanded, it's really the AST node it is attached to that gets entirely replaced.
There was a problem hiding this comment.
Ok, thanks for clarifying.
There was a problem hiding this comment.
Should the expanded items then be ordered, i.e. getExpanded(int i) instead of just getExpanded()?
| @@ -1945,4 +1944,4 @@ class FormatArgument(Locatable): | |||
|
|
|||
| @annotate(Item, add_bases=(Addressable,)) | |||
| class _: | |||
| pass | |||
| expanded: optional[AstNode] | child | rust.detach | doc("expanded attribute or procedural macro call of this item") | |||
There was a problem hiding this comment.
Would it be better to have a new base class, say Expandable, for this?
There was a problem hiding this comment.
considering that MacroCall is also an Item, and that the only remaining case to cover (derive macros) also applies to Items, I don't see the need for another class in the hierarchy. What do you think would be the advantage of such an additional class?
There was a problem hiding this comment.
In light of your reply to my question above, this question is no longer relevant.
|
I have started a DCA run. |
No description provided.