x/tools/gopls: handle undefined struct type in undeclaredname autofix code action

[phiros]

gopls version

golang.org/x/tools/gopls v0.16.2

go env

not relevant

What did you do?

I ran an autofix code action for an undefined struct.

What did you see happen?

gopls generated a new variable instead of a struct type definition.
This is nonsensical from a user point of view & also doesn't compile.

What did you expect to see?

A struct type definition above the function body.

Editor and settings

No response

Logs

No response

[gabyhelp]

Related Issues and Documentation

• x/tools/gopls: misleading quick fix (`gopls.apply_fix`) for undefined type constraint #50935 (closed)
• x/tools/gopls: code action for “add field names to struct literal” #43198 (closed)
• x/tools/gopls: feature: code action to generate a stub function from a "no function f" type error #69692 (closed)

_{(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)}

[phiros]

Note that I already have a fix ready for the above issue that modifies the undeclaredname analyzer.
My understanding is that I have to create this issue first before submitting the change.

[gopherbot]

Change https://go.dev/cl/621295 mentions this issue: gopls: handle undefined struct type in undeclaredname

[adonovan]

Note that I already have a fix ready for the above issue that modifies the undeclaredname analyzer.
My understanding is that I have to create this issue first before submitting the change.

Generally one should also wait for consensus that the feature is useful, but in this case I agree that it is. Thanks for contributing.

[findleyr]

Thanks for contributing this feature! I'll put this in the [email protected] milestone, assuming it lands expediently.