Skip to content

runtime: add missing persistentalloc memstats #46051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hzzb
Copy link
Contributor

@hzzb hzzb commented May 8, 2021

Before this commit, every persistentalloc call got one of memstats
statistics except when allocating mheap.arenas L2 array. If passing
nil sysStat into function persistentalloc, the memory allocated will
not be accounted.

Two changes after this commit:

  1. Account mheap.arenas L2 array allocation into memestats.gcMiscSys
  2. Fallback to memestats.other_sys if persistentalloc got nil sysStat

Before this commit, every persistentalloc call got one of memstats
statistics except when allocating mheap.arenas L2 array. If passing
nil sysStat into function persistentalloc, the memory allocated will
not be accounted.

Two changes after this commit:
1. Account mheap.arenas L2 array allocation into memestats.gcMiscSys
2. Fallback to memestats.other_sys if persistentalloc got nil sysStat
@google-cla google-cla bot added the cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. label May 8, 2021
@gopherbot
Copy link
Contributor

This PR (HEAD: 91b868f) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/317932 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Michael Knyszek:

Patch Set 1:

(2 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/317932.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Michael Knyszek:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/317932.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Michael Knyszek:

Patch Set 1:

(2 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/317932.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Michael Knyszek:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/317932.
After addressing review feedback, remember to publish your drafts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants