Skip to content

math: add ARM64 implementation of hypot #47536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

math: add ARM64 implementation of hypot #47536

wants to merge 1 commit into from
+59 −2

Conversation

howjmay
Copy link
Contributor

@howjmay howjmay commented Aug 4, 2021

Add ARM64 assembly implementation of hypot. The benchmark which run on
Apple Silicon M1 chip is listed as following.

BenchmarkHypot
BenchmarkHypot-8 2.185 ns/op 0 B/op 0 allocs/op
BenchmarkHypotGo
BenchmarkHypotGo-8 3.462 ns/op 0 B/op 0 allocs/op

delta: -36.89%

@google-cla google-cla bot added the cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. label Aug 4, 2021
@gopherbot
Copy link
Contributor

This PR (HEAD: 1bc07c8) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/339849 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Hau Yang:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/339849.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Robert Griesemer:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/339849.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from fannie zhang:

Patch Set 1: Run-TryBot+1

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/339849.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go Bot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/339849.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go Bot:

Patch Set 1: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/339849.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: 52f73f1) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/339849 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Hau Yang:

Patch Set 2:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/339849.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: e85ba85) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/339849 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Russ Cox:

Patch Set 3: Hold+1

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/339849.
After addressing review feedback, remember to publish your drafts!

@ianlancetaylor @howjmay
doc/go1.19: Linux race detector now requires glibc 2.17
1d646a5 
Fixes golang#53522

Change-Id: Ibed838d358a733d26a6c3d89446d7fadb1012961
Reviewed-on: https://go-review.googlesource.com/c/go/+/413876
Reviewed-by: Keith Randall <[email protected]>
Reviewed-by: Keith Randall <[email protected]>
Reviewed-by: Ian Lance Taylor <[email protected]>
Run-TryBot: Ian Lance Taylor <[email protected]>
Auto-Submit: Ian Lance Taylor <[email protected]>
Run-TryBot: Ian Lance Taylor <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
@gopherbot
Copy link
Contributor

This PR (HEAD: 1d646a5) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/339849 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Hau Yang:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/339849.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Hau Yang:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/339849.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Robert Griesemer:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/339849.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Fannie Zhang:

Patch Set 1: Run-TryBot+1

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/339849.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/339849.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 1: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/339849.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Hau Yang:

Patch Set 2:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/339849.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Russ Cox:

Patch Set 3: Hold+1

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/339849.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Hau Yang:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/339849.
After addressing review feedback, remember to publish your drafts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@howjmay @gopherbot @ianlancetaylor