net/http: explain when HTTP/2 is disabled #64708

jsha · 2023-12-14T00:17:07Z

Previously the docs simply said HTTP/2 is disabled for "simple configurations." Instead, say which specific configurations disable HTTP/2.

Also, the sentence "... Transport and Server both automatically enable HTTP/2 support for simple configurations" was redundant with the sentence at the start of the section:

"Starting with Go 1.6, the http package has transparent support for the HTTP/2 protocol when using HTTPS."

Several fields of Transport can disable HTTP/2 support, but only one (TLSClientConfig) was documented to do so. Add consistent documentation to each of them.

Background:

For letsencrypt/boulder, we're adding DoH support to talk to Unbound. Unbound requires HTTP/2. We configured a custom root certificate since our internal Unbound uses an internal PKI. We were puzzled to get errors and had trouble tracking down why HTTP/2 wasn't happening, despite checking the docs several times. Hopefully this change can make things clearer for future readers.

Previously the docs simply said HTTP/2 is disabled for "simple configurations." Instead, say which specific configurations disable HTTP/2. Also, the sentence "... Transport and Server both automatically enable HTTP/2 support for simple configurations" was redundant with the sentence at the start of the section: "Starting with Go 1.6, the http package has transparent support for the HTTP/2 protocol when using HTTPS." Several fields of Transport can disable HTTP/2 support, but only one (TLSClientConfig) was documented to do so. Add consistent documentation to each of them.

gopherbot · 2023-12-14T00:25:32Z

This PR (HEAD: 9bf970f) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/549519.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2023-12-14T00:32:02Z

Message from Gopher Robot:

Patch Set 1:

(1 comment)