-
Notifications
You must be signed in to change notification settings - Fork 18k
cmd/compile/internal/ssa: merge more loc lists #65006
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
This PR (HEAD: 4b1a278) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/554515. Important tips:
|
Message from Jorropo: Patch Set 1: Run-TryBot+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/554515. |
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/554515. |
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/554515. |
Message from Gopher Robot: Patch Set 1: TryBot-Result-1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/554515. |
Before this change, the logic to merge location lists would choose not to merge if the old and new entries were both on the stack, but the new entry was in fewer registers than old one or if both locations were in registers but the new one is no longer in a register that was not going to be output. Fixes golang#65005
4b1a278
to
52390a6
Compare
This PR (HEAD: 52390a6) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/554515. Important tips:
|
Message from Andrew Werner: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/554515. |
Message from Jorropo: Patch Set 2: Run-TryBot+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/554515. |
Message from Gopher Robot: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/554515. |
Message from Gopher Robot: Patch Set 2: TryBot-Result+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/554515. |
Message from Jorropo: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/554515. |
Before this change, the logic to merge location lists would choose not
to merge if the old and new entries were both on the stack, but the new
entry was in fewer registers than old one or if both locations were in
registers but the new one is no longer in a register that was not going
to be output.
Fixes #65005