-
Notifications
You must be signed in to change notification settings - Fork 18k
html: sync changes from x/net #66970
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
This PR (HEAD: af7627f) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/580896. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/580896. |
Message from Luke Shumaker: Patch Set 1: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/580896. |
Message from Luke Shumaker: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/580896. |
Message from Ian Lance Taylor: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/580896. |
Message from Luke Shumaker: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/580896. |
Message from Ian Lance Taylor: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/580896. |
Message from Damien Neil: Patch Set 1: (3 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/580896. |
Message from Nigel Tao: Patch Set 1: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/580896. |
Before 324513b (2012-01-04) std "html" and what is now "golang.org/x/net/html" were the same. Ever since then (well, since 4e0749a (2012-05-29)) the escape/unescape code that they share has been drifting apart, each receiving separate improvements. This CL cherry-picks over all of the changes that "x/net/html" has seen. This is the counterpart to https://golang.org/cl/580855, and so also includes the de-duplication requested at https://go-review.googlesource.com/c/net/+/580855/comment/8f8679a3_12b9ead1/ golang@4e0749a : Author: Andrew Balholm <[email protected]> Date: Wed May 30 15:50:12 2012 +1000 exp/html: Convert \r and \r\n to \n when tokenizing Also escape "\r" as "&golang#13;" when rendering HTML. Pass 2 additional tests. R=nigeltao CC=golang-dev https://golang.org/cl/6260046 golang/net@3d87fd6 : Author: Dmitry Savintsev <[email protected]> Date: Thu Feb 26 23:44:25 2015 +0100 x/net/html: Sync the html parser and atom with the current whatwg spec The current documentation as well as set of atoms and attributes has gotten slightly out of sync with the current state of the WHATWG html5 specification. The change adds and removes several of the atoms and attributes, updates the documentation (such as steps numbering in inBodyEndTagFormatting) and modifies the spec URLs to https:// Change-Id: I6dfa52785858c1521301b20b1e585e19a08b1e98 Reviewed-on: https://go-review.googlesource.com/6173 Reviewed-by: Nigel Tao <[email protected]>
af7627f
to
c668d2e
Compare
This PR (HEAD: c668d2e) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/580896. Important tips:
|
Message from Gopher Robot: Patch Set 2: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/580896. |
Message from Luke T. Shumaker: Patch Set 2: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/580896. |
Before 324513b (2012-01-04) std "html" and what is now
"golang.org/x/net/html" were the same. Ever since then (well, since
4e0749a (2012-05-29)) the escape/unescape code that they share has
been drifting apart, each receiving separate improvements.
This CL cherry-picks over all of the changes that "x/net/html" has
seen.
This is the counterpart to https://golang.org/cl/580855, and so also
includes the de-duplication requested at
https://go-review.googlesource.com/c/net/+/580855/comment/8f8679a3_12b9ead1/
4e0749a :
golang/net@3d87fd6 :