log/slog: export Source method in Record for custom handler support #70281

nesty92 · 2024-11-11T08:58:44Z

Currently, the source method in slog.Record is not accessible to
custom handlers, requiring developers to re-implement logic for
retrieving source location information. This commit exports the source
method as Source, enabling consistent access for custom logging
handlers and reducing code redundancy.

Fixes #70280

google-cla · 2024-11-11T08:58:49Z

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

gopherbot · 2024-11-11T09:16:56Z

This PR (HEAD: 5c37e88) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/626976.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-11-11T09:24:33Z

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/626976.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-11T09:24:34Z

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11 or adds a tag like "wait-release", it means that this CL will be
reviewed as part of the next development cycle. See https://go.dev/s/release
for more details.

Please don’t reply on this GitHub thread. Visit golang.org/cl/626976.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-11T09:39:45Z

Message from Ernesto Alejandro Santana:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/626976.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-12T02:59:30Z

Message from Jonathan Amsterdam:

Patch Set 2: Hold+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/626976.
After addressing review feedback, remember to publish your drafts!

Currently, the `source` method in `slog.Record` is not accessible to custom handlers, requiring developers to re-implement logic for retrieving source location information. This commit exports the `source` method as `Source`, enabling consistent access for custom logging handlers and reducing code redundancy. Fixes golang#70280 Change-Id: I3eb3bc60658abc5de95697a10bddd11ab54c6e13 GitHub-Last-Rev: 5c37e88 GitHub-Pull-Request: golang#70281

gopherbot · 2024-11-12T13:50:56Z

This PR (HEAD: 9121c71) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/626976.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

Currently, the `source` method in `slog.Record` is not accessible to custom handlers, requiring developers to re-implement logic for retrieving source location information. This commit exports the `source` method as `Source`, enabling consistent access for custom logging handlers and reducing code redundancy. Fixes golang#70280 Change-Id: I3eb3bc60658abc5de95697a10bddd11ab54c6e13 GitHub-Last-Rev: 5c37e88 GitHub-Pull-Request: golang#70281 Signed-off-by: Ernesto Alejandro Santana Hidalgo <[email protected]>

gopherbot · 2025-04-24T08:23:27Z

This PR (HEAD: ec6e88c) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/626976.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2025-04-24T08:31:55Z

This PR (HEAD: 5ea3796) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/626976.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2025-04-24T12:17:15Z

Message from Jonathan Amsterdam:

Patch Set 5: Hold+1

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/626976.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-04-24T14:19:14Z

This PR (HEAD: f81428e) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/626976.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2025-04-24T14:27:28Z

Message from Ernesto Alejandro Santana:

Patch Set 6:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/626976.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-04-24T14:43:05Z

Message from Jonathan Amsterdam:

Patch Set 6: Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/626976.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-04-24T14:43:06Z

Message from Jonathan Amsterdam:

Patch Set 6: -Hold

Please don’t reply on this GitHub thread. Visit golang.org/cl/626976.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-04-24T14:43:06Z

Message from Jonathan Amsterdam:

Patch Set 6:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/626976.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-04-24T15:07:03Z

This PR (HEAD: 214dc8b) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/626976.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2025-04-24T15:21:55Z

Message from Ernesto Alejandro Santana:

Patch Set 6:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/626976.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-04-24T17:07:05Z

Message from Jonathan Amsterdam:

Patch Set 7:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/626976.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-04-24T17:50:12Z

This PR (HEAD: 468119e) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/626976.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2025-04-24T17:58:02Z

Message from Ernesto Alejandro Santana:

Patch Set 7:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/626976.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-04-24T19:17:29Z

Message from Jonathan Amsterdam:

Patch Set 8: Code-Review+2 Commit-Queue+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/626976.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-04-24T19:24:06Z

Message from Go LUCI:

Patch Set 8:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2025-04-24T19:09:29Z","revision":"cf8cfe42dd37b0409dbda0336f4bcac7b099f0a3"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/626976.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-04-24T19:24:06Z

Message from Jonathan Amsterdam:

Patch Set 8: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/626976.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-04-24T19:24:07Z

Message from Go LUCI:

Patch Set 8:

This CL has failed the run. Reason:

Tryjob golang/try/x_tools-gotip-linux-amd64 has failed with summary (view all results):

go on master (change 626976) / tools on master (commit 2f3d4ad)

To reproduce, try gomote repro 8716681476098245041.

Additional links for debugging:

test golang.org/x/tools module output

Please don’t reply on this GitHub thread. Visit golang.org/cl/626976.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-04-24T19:24:08Z

Message from Go LUCI:

Patch Set 8: LUCI-TryBot-Result-1

Please don’t reply on this GitHub thread. Visit golang.org/cl/626976.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-04-24T20:41:57Z

Message from Jonathan Amsterdam:

Patch Set 8:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/626976.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-04-24T20:48:58Z

Message from Jonathan Amsterdam:

Patch Set 8: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/626976.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-04-24T20:48:59Z

Message from Go LUCI:

Patch Set 8:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2025-04-24T20:31:39Z","revision":"cf8cfe42dd37b0409dbda0336f4bcac7b099f0a3"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/626976.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-04-24T20:48:59Z

Message from Jonathan Amsterdam:

Patch Set 8: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/626976.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-04-24T20:49:00Z

Message from Go LUCI:

Patch Set 8:

This CL has failed the run. Reason:

Failed Tryjobs:

golang/try/gotip-linux-386_debiansid. Summary (view all results):

go on master (change 626976)

To reproduce, try gomote repro 8716676305982812689.

Additional links for debugging:

go tool dist test -json output [shard 1]

golang/try/gotip-linux-arm64. Summary (view all results):

go on master (change 626976)

To reproduce, try gomote repro 8716676305982812561.

Additional links for debugging:

go tool dist test -json output [shard 1]

Please don’t reply on this GitHub thread. Visit golang.org/cl/626976.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-04-24T23:45:44Z

Message from Jonathan Amsterdam:

Patch Set 9: Code-Review+2 Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/626976.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-04-24T23:52:31Z

Message from Go LUCI:

Patch Set 9:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2025-04-24T23:38:52Z","revision":"d1f4f2eb814e785bf5e9f567da3f74b14aa9bf35"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/626976.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-04-24T23:59:11Z

Message from Jonathan Amsterdam:

Patch Set 9: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/626976.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-04-24T23:59:11Z

Message from Go LUCI:

Patch Set 9:

This CL has failed the run. Reason:

Tryjob golang/try/gotip-linux-amd64_debiansid has failed with summary (view all results):

go on master (change 626976)

To reproduce, try gomote repro 8716664529383977345.

Additional links for debugging:

Please don’t reply on this GitHub thread. Visit golang.org/cl/626976.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-04-24T23:59:12Z

Message from Go LUCI:

Patch Set 9: LUCI-TryBot-Result-1

Please don’t reply on this GitHub thread. Visit golang.org/cl/626976.
After addressing review feedback, remember to publish your drafts!

Following proposal golang#70280 Signed-off-by: Ernesto Alejandro Santana Hidalgo <[email protected]>

gopherbot · 2025-04-25T05:53:33Z

This PR (HEAD: 0dc2b06) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/626976.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2025-04-25T13:35:01Z

Message from Ernesto Alejandro Santana:

Patch Set 10:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/626976.
After addressing review feedback, remember to publish your drafts!

nesty92 closed this Nov 12, 2024

nesty92 force-pushed the master branch from 5c37e88 to 9121c71 Compare November 12, 2024 13:47

nesty92 reopened this Nov 12, 2024

nesty92 force-pushed the master branch from 9121c71 to ec6e88c Compare April 24, 2025 08:16

nesty92 force-pushed the master branch from ec6e88c to 5ea3796 Compare April 24, 2025 08:23

nesty92 force-pushed the master branch from 5ea3796 to f81428e Compare April 24, 2025 14:13

nesty92 force-pushed the master branch from f81428e to 214dc8b Compare April 24, 2025 15:03

nesty92 force-pushed the master branch from 214dc8b to 468119e Compare April 24, 2025 17:46

log/slog: update Source method to return nil for unavailable locations

0dc2b06

Following proposal golang#70280 Signed-off-by: Ernesto Alejandro Santana Hidalgo <[email protected]>

nesty92 force-pushed the master branch from 468119e to 0dc2b06 Compare April 25, 2025 04:11

log/slog: export Source method in Record for custom handler support #70281

Are you sure you want to change the base?

log/slog: export Source method in Record for custom handler support #70281

Conversation

nesty92 commented Nov 11, 2024 • edited Loading

google-cla bot commented Nov 11, 2024

gopherbot commented Nov 11, 2024

gopherbot commented Nov 11, 2024

gopherbot commented Nov 11, 2024

gopherbot commented Nov 11, 2024

gopherbot commented Nov 12, 2024

gopherbot commented Nov 12, 2024

gopherbot commented Apr 24, 2025

gopherbot commented Apr 24, 2025

gopherbot commented Apr 24, 2025

gopherbot commented Apr 24, 2025

gopherbot commented Apr 24, 2025

gopherbot commented Apr 24, 2025

gopherbot commented Apr 24, 2025

gopherbot commented Apr 24, 2025

gopherbot commented Apr 24, 2025

gopherbot commented Apr 24, 2025

gopherbot commented Apr 24, 2025

gopherbot commented Apr 24, 2025

gopherbot commented Apr 24, 2025

gopherbot commented Apr 24, 2025

gopherbot commented Apr 24, 2025

gopherbot commented Apr 24, 2025

gopherbot commented Apr 24, 2025

gopherbot commented Apr 24, 2025

gopherbot commented Apr 24, 2025

gopherbot commented Apr 24, 2025

gopherbot commented Apr 24, 2025

gopherbot commented Apr 24, 2025

gopherbot commented Apr 24, 2025

gopherbot commented Apr 24, 2025

gopherbot commented Apr 24, 2025

gopherbot commented Apr 24, 2025

gopherbot commented Apr 24, 2025

gopherbot commented Apr 24, 2025

gopherbot commented Apr 25, 2025

gopherbot commented Apr 25, 2025

nesty92 commented Nov 11, 2024 •

edited

Loading